apply requested pr changes

Signed-off-by: Matteo Silvestri <matteosilv@gmail.com>
This commit is contained in:
Matteo Silvestri
2022-09-01 11:49:59 +02:00
parent 8a59bedadd
commit 9b05fd5f93
3 changed files with 9 additions and 9 deletions
+5 -7
View File
@@ -1,10 +1,10 @@
name: KubernetesContainerRunner
name: E2E Test Kubernetes
on:
pull_request:
paths:
- 'yarn.lock'
- '.github/workflows/verify_kubernetes.yml'
- 'packages/backend-common/src/util/**'
- 'packages/backend-common/src/**'
jobs:
verify:
@@ -16,12 +16,10 @@ jobs:
env:
CI: true
KUBERNETES: true
KUBERNETES_TESTS: true
steps:
- uses: actions/checkout@v3
- name: fetch branch master
run: git fetch origin master
- name: use node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
@@ -37,6 +35,6 @@ jobs:
- name: bootstrap kind
uses: helm/kind-action@v1.3.0
- name: techdocs-cli kubernetes test
- name: kubernetes test
working-directory: packages/backend-common
run: yarn test:kubernetes:ci
run: yarn test:kubernetes
+1 -1
View File
@@ -32,7 +32,7 @@
"postpack": "backstage-cli package postpack",
"clean": "backstage-cli package clean",
"start": "backstage-cli package start",
"test:kubernetes:ci": "backstage-cli test -t KubernetesContainerRunner --watchAll=false --ci"
"test:kubernetes": "backstage-cli package test -t KubernetesContainerRunner --no-watch"
},
"dependencies": {
"@backstage/cli-common": "^0.1.9",
@@ -26,7 +26,9 @@ import {
import { RunContainerOptions } from './ContainerRunner';
import { PassThrough } from 'stream';
const describeIfKubernetes = Boolean(process.env.KUBERNETES)
// This ensures E2E tests that require a Kubernetes cluster are only run
// where KUBERNETES_TESTS environment variable is true
const describeIfKubernetes = Boolean(process.env.KUBERNETES_TESTS)
? describe
: describe.skip;