refactor: apply review suggestions

Signed-off-by: Camila Belo <camilaibs@gmail.com>

plugins/techdocs-node/api-report.md

@@ -12,6 +12,7 @@ import { Entity } from '@backstage/catalog-model';
 import express from 'express';
 import { ExtensionPoint } from '@backstage/backend-plugin-api';
 import { IndexableDocument } from '@backstage/plugin-search-common';
+import { Logger } from 'winston';
 import { LoggerService } from '@backstage/backend-plugin-api';
 import { ScmIntegrationRegistry } from '@backstage/integration';
 import { UrlReaderService } from '@backstage/backend-plugin-api';
@@ -57,7 +58,7 @@ export type GeneratorRunOptions = {
   outputDir: string;
   parsedLocationAnnotation?: ParsedLocationAnnotation;
   etag?: string;
-  logger: LoggerService;
+  logger: Logger;
   logStream?: Writable;
   siteOptions?: {
     name?: string;

plugins/techdocs-node/package.json

@@ -53,7 +53,6 @@
     "@aws-sdk/types": "^3.347.0",
     "@azure/identity": "^4.0.0",
     "@azure/storage-blob": "^12.5.0",
-    "@backstage/backend-common": "workspace:^",
     "@backstage/backend-plugin-api": "workspace:^",
     "@backstage/catalog-model": "workspace:^",
     "@backstage/config": "workspace:^",

plugins/techdocs-node/src/stages/generate/types.ts

@@ -16,6 +16,7 @@
 
 import { Entity } from '@backstage/catalog-model';
 import { Writable } from 'stream';
+import { Logger } from 'winston';
 import { ParsedLocationAnnotation } from '../../helpers';
 import { LoggerService } from '@backstage/backend-plugin-api';
 import { TechDocsContainerRunner } from '../publish/types';
@@ -65,7 +66,7 @@ export type GeneratorRunOptions = {
   outputDir: string;
   parsedLocationAnnotation?: ParsedLocationAnnotation;
   etag?: string;
-  logger: LoggerService;
+  logger: Logger;
   logStream?: Writable;
   siteOptions?: { name?: string };
   runAsDefaultUser?: boolean;

plugins/techdocs-node/src/stages/publish/azureBlobStorage.test.ts

@@ -224,7 +224,6 @@ const getEntityRootDir = (entity: Entity) => {
 };
 
 const logger = mockServices.logger.mock();
-jest.spyOn(logger, 'error');
 
 const createPublisherFromConfig = ({
   accountName = 'accountName',

plugins/techdocs-node/src/stages/publish/googleStorage.test.ts

@@ -139,8 +139,6 @@ const getEntityRootDir = (entity: Entity) => {
 };
 
 const logger = mockServices.logger.mock();
-jest.spyOn(logger, 'info');
-jest.spyOn(logger, 'error');
 
 const createPublisherFromConfig = ({
   bucketName = 'bucketName',

yarn.lock

@@ -7651,7 +7651,6 @@ __metadata:
     "@aws-sdk/types": ^3.347.0
     "@azure/identity": ^4.0.0
     "@azure/storage-blob": ^12.5.0
-    "@backstage/backend-common": "workspace:^"
     "@backstage/backend-plugin-api": "workspace:^"
     "@backstage/backend-test-utils": "workspace:^"
     "@backstage/catalog-model": "workspace:^"