Apply suggestions from code review
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
@@ -3,7 +3,7 @@
|
||||
'@backstage/plugin-techdocs': patch
|
||||
---
|
||||
|
||||
Google Cloud authentication in TechDocs has been improved. https://github.com/backstage/backstage/pull/3981
|
||||
Google Cloud authentication in TechDocs has been improved.
|
||||
|
||||
`techdocs.publisher.googleGcs.credentials` is now optional. If it is missing, `GOOGLE_APPLICATION_CREDENTIALS`
|
||||
environment variable (and some other methods) will be used to authenticate.
|
||||
|
||||
@@ -180,7 +180,7 @@ In the IAM console, do the following:
|
||||
**2.2 Attach policies**
|
||||
|
||||
Remember that you can use Bucket policy **or** User policy. Just make sure that
|
||||
you grant all the permissions to the TechDocs user: `3:PutObject`,
|
||||
you grant all the permissions to the TechDocs user: `s3:PutObject`,
|
||||
`s3:GetObject`, `s3:ListBucket` and `s3:GetBucketLocation`.
|
||||
|
||||
**2.2.1 Create the bucket policy**
|
||||
|
||||
@@ -72,7 +72,7 @@ export class GoogleGCSPublish implements PublisherBase {
|
||||
logger.error(
|
||||
`Could not retrieve metadata about the GCS bucket ${bucketName}. ` +
|
||||
'Make sure the bucket exists. Also make sure that authentication is setup either by explicitly defining ' +
|
||||
'techdocs.publisher.googleGcs.credentials in app config or by using environment variables' +
|
||||
'techdocs.publisher.googleGcs.credentials in app config or by using environment variables. ' +
|
||||
'Refer to https://backstage.io/docs/features/techdocs/using-cloud-storage',
|
||||
);
|
||||
throw new Error(err.message);
|
||||
|
||||
Reference in New Issue
Block a user