Refactor: remove env parameter from callbackURL of all OAuth based

providers
This commit is contained in:
Govindarajan Nagarajan
2020-08-06 12:48:02 +02:00
parent 5f06a08daa
commit 959cc6fe86
4 changed files with 8 additions and 8 deletions
@@ -126,7 +126,7 @@ export class GithubAuthProvider implements OAuthProviderHandlers {
export function createGithubProvider(
{ baseUrl }: AuthProviderConfig,
env: string,
_: string,
envConfig: Config,
logger: Logger,
tokenIssuer: TokenIssuer,
@@ -148,7 +148,7 @@ export function createGithubProvider(
const userProfileURL = enterpriseInstanceUrl
? `${enterpriseInstanceUrl}/api/v3/user`
: undefined;
const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`;
const callbackURL = `${baseUrl}/${providerId}/handler/frame`;
const opts = {
clientID,
@@ -133,7 +133,7 @@ export class GitlabAuthProvider implements OAuthProviderHandlers {
export function createGitlabProvider(
{ baseUrl }: AuthProviderConfig,
env: string,
_: string,
envConfig: Config,
logger: Logger,
tokenIssuer: TokenIssuer,
@@ -145,7 +145,7 @@ export function createGitlabProvider(
const clientSecret = envConfig.getString('clientSecret');
const audience = envConfig.getString('audience');
const baseURL = audience || 'https://gitlab.com';
const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`;
const callbackURL = `${baseUrl}/${providerId}/handler/frame`;
const opts = {
clientID,
@@ -145,7 +145,7 @@ export class GoogleAuthProvider implements OAuthProviderHandlers {
export function createGoogleProvider(
{ baseUrl }: AuthProviderConfig,
env: string,
_: string,
envConfig: Config,
logger: Logger,
tokenIssuer: TokenIssuer,
@@ -155,7 +155,7 @@ export function createGoogleProvider(
const appOrigin = envConfig.getString('appOrigin');
const clientID = envConfig.getString('clientId');
const clientSecret = envConfig.getString('clientSecret');
const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`;
const callbackURL = `${baseUrl}/${providerId}/handler/frame`;
const opts = {
clientID,
@@ -165,7 +165,7 @@ export class OktaAuthProvider implements OAuthProviderHandlers {
export function createOktaProvider(
{ baseUrl }: AuthProviderConfig,
env: string,
_: string,
envConfig: Config,
logger: Logger,
tokenIssuer: TokenIssuer,
@@ -176,7 +176,7 @@ export function createOktaProvider(
const clientID = envConfig.getString('clientId');
const clientSecret = envConfig.getString('clientSecret');
const audience = envConfig.getString('audience');
const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`;
const callbackURL = `${baseUrl}/${providerId}/handler/frame`;
const opts = {
audience,