rename count to totalItems

Signed-off-by: Aramis <sennyeyaramis@gmail.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
This commit is contained in:
Aramis
2024-01-26 11:53:36 -05:00
committed by aramissennyeydd
parent 59bf5009a8
commit 9291354f99
6 changed files with 17 additions and 16 deletions
+1 -1
View File
@@ -306,7 +306,7 @@ export type EntityListContextProps<
next?: () => void;
prev?: () => void;
};
count?: number;
totalItems?: number;
};
// @public
@@ -235,7 +235,7 @@ describe('<EntityListProvider />', () => {
await waitFor(() => {
expect(result.current.entities.length).toBe(1);
});
expect(result.current.count).toBe(1);
expect(result.current.totalItems).toBe(1);
await expect(() =>
waitFor(() => {
@@ -252,7 +252,7 @@ describe('<EntityListProvider />', () => {
await waitFor(() => {
expect(result.current.backendEntities.length).toBeGreaterThan(0);
});
expect(result.current.count).toBe(2);
expect(result.current.totalItems).toBe(2);
expect(result.current.backendEntities.length).toBe(2);
expect(mockCatalogApi.getEntities).toHaveBeenCalledTimes(1);
@@ -278,7 +278,7 @@ describe('<EntityListProvider />', () => {
});
expect(result.current.backendEntities.length).toBe(2);
expect(result.current.count).toBe(2);
expect(result.current.totalItems).toBe(2);
mockCatalogApi.getEntities!.mockRejectedValueOnce('error');
act(() => {
@@ -460,7 +460,7 @@ describe('<EntityListProvider pagination />', () => {
});
});
expect(result.current.count).toBe(10);
expect(result.current.totalItems).toBe(10);
});
it('returns an error on catalogApi failure', async () => {
@@ -109,7 +109,7 @@ export type EntityListContextProps<
prev?: () => void;
};
count?: number;
totalItems?: number;
};
/**
@@ -126,7 +126,7 @@ type OutputState<EntityFilters extends DefaultEntityFilters> = {
entities: Entity[];
backendEntities: Entity[];
pageInfo?: QueryEntitiesResponse['pageInfo'];
count?: number;
totalItems?: number;
};
/**
@@ -226,7 +226,7 @@ export const EntityListProvider = <EntityFilters extends DefaultEntityFilters>(
backendEntities: response.items,
entities: response.items.filter(entityFilter),
pageInfo: response.pageInfo,
count: response.totalItems,
totalItems: response.totalItems,
});
}
} else {
@@ -247,7 +247,7 @@ export const EntityListProvider = <EntityFilters extends DefaultEntityFilters>(
backendEntities: response.items,
entities: response.items.filter(entityFilter),
pageInfo: response.pageInfo,
count: response.totalItems,
totalItems: response.totalItems,
});
}
}
@@ -272,7 +272,7 @@ export const EntityListProvider = <EntityFilters extends DefaultEntityFilters>(
appliedFilters: requestedFilters,
backendEntities: response.items,
entities,
count: entities.length,
totalItems: entities.length,
});
} else {
const entities = outputState.backendEntities.filter(entityFilter);
@@ -280,7 +280,7 @@ export const EntityListProvider = <EntityFilters extends DefaultEntityFilters>(
appliedFilters: requestedFilters,
backendEntities: outputState.backendEntities,
entities,
count: entities.length,
totalItems: entities.length,
});
}
}
@@ -361,7 +361,7 @@ export const EntityListProvider = <EntityFilters extends DefaultEntityFilters>(
loading,
error,
pageInfo,
count: outputState.count,
totalItems: outputState.totalItems,
}),
[outputState, updateFilters, queryParameters, loading, error, pageInfo],
);
@@ -71,7 +71,8 @@ export function MockEntityListContextProvider<
loading: value?.loading ?? false,
queryParameters: value?.queryParameters ?? defaultValues.queryParameters,
error: value?.error,
count: (value?.entities ?? defaultValues.entities).length,
totalItems:
value?.totalItems ?? (value?.entities ?? defaultValues.entities).length,
}),
[value, defaultValues, filters, updateFilters],
);
@@ -88,7 +88,7 @@ export const CatalogTable = (props: CatalogTableProps) => {
} = props;
const { isStarredEntity, toggleStarredEntity } = useStarredEntities();
const entityListContext = useEntityList();
const { loading, error, entities, filters, pageInfo, count } =
const { loading, error, entities, filters, pageInfo, totalItems } =
entityListContext;
const enablePagination = !!pageInfo;
@@ -176,7 +176,7 @@ export const CatalogTable = (props: CatalogTableProps) => {
.filter(s => s)
.join(' ');
const title = `${titleDisplay} (${count})`;
const title = `${titleDisplay} (${totalItems})`;
const actions = props.actions || defaultActions;
const options = {
actionsColumnIndex: -1,
@@ -142,7 +142,7 @@ describe('PaginatedCatalogTable', () => {
<MockEntityListContextProvider
value={{
entities: data.map(e => e.entity),
count: data.length,
totalItems: data.length,
filters: {
kind: new EntityKindFilter('component'),
},