Merge pull request #24134 from Sarabadu/add-mui-imports-lint-rule-to-packages

Add mui imports lint rule to `packages/*`

.changeset/healthy-suns-perform.md

@@ -0,0 +1,5 @@
+---
+'@backstage/frontend-app-api': patch
+---
+
+add `@backstage/no-top-level-material-ui-4-imports` lint rule

packages/app-defaults/.eslintrc.js

@@ -1 +1,5 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
+  rules: {
+    '@backstage/no-top-level-material-ui-4-imports': 'error',
+  },
+});

packages/app-next-example-plugin/.eslintrc.js

@@ -1 +1,5 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
+  rules: {
+    '@backstage/no-top-level-material-ui-4-imports': 'error',
+  },
+});

packages/frontend-app-api/.eslintrc.js

@@ -1 +1,5 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
+  rules: {
+    '@backstage/no-top-level-material-ui-4-imports': 'error',
+  },
+});

packages/frontend-app-api/src/extensions/AppNav.tsx

@@ -23,7 +23,7 @@ import {
   createNavItemExtension,
   createNavLogoExtension,
 } from '@backstage/frontend-plugin-api';
-import { makeStyles } from '@material-ui/core';
+import { makeStyles } from '@material-ui/core/styles';
 import {
   Sidebar,
   useSidebarOpenState,

packages/frontend-app-api/src/extensions/components.tsx

@@ -16,7 +16,7 @@
 
 import React from 'react';
 // TODO: Dependency on MUI should be removed from core packages
-import { Button } from '@material-ui/core';
+import Button from '@material-ui/core/Button';
 
 import {
   createComponentExtension,

packages/frontend-plugin-api/.eslintrc.js

@@ -1 +1,5 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
+  rules: {
+    '@backstage/no-top-level-material-ui-4-imports': 'error',
+  },
+});

packages/integration-react/.eslintrc.js

@@ -1 +1,5 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
+  rules: {
+    '@backstage/no-top-level-material-ui-4-imports': 'error',
+  },
+});

packages/integration-react/dev/DevPage.tsx

@@ -15,7 +15,7 @@
  */
 
 import { ScmIntegration, ScmIntegrationsGroup } from '@backstage/integration';
-import { Typography } from '@material-ui/core';
+import Typography from '@material-ui/core/Typography';
 import React from 'react';
 import { scmIntegrationsApiRef } from '../src/ScmIntegrationsApi';