addressing code review comments

Signed-off-by: Brian Fletcher <brian@roadie.io>

packages/backend/src/plugins/DemoEventBasedEntityProvider.ts

@@ -22,7 +22,9 @@ import { EventParams, EventSubscriber } from '@backstage/plugin-events-node';
 import { Logger } from 'winston';
 import { PluginEnvironment } from '../types';
 
-class DemoEventBasedEntityProvider implements EntityProvider, EventSubscriber {
+export class DemoEventBasedEntityProvider
+  implements EntityProvider, EventSubscriber
+{
   constructor(
     private readonly logger: Logger,
     private readonly topics: string[],
@@ -55,7 +57,7 @@ export default async function createCatalogEventBasedProviders(
   const providers: Array<
     (EntityProvider & EventSubscriber) | Array<EntityProvider & EventSubscriber>
   > = [];
-  providers.push(new DemoEventBasedEntityProvider(env.logger, ['example']));
+  providers.push();
   // add your event-based entity providers here
   return providers.flat();
 }

packages/backend/src/plugins/catalog.ts

@@ -18,16 +18,20 @@ import { CatalogBuilder } from '@backstage/plugin-catalog-backend';
 import { ScaffolderEntitiesProcessor } from '@backstage/plugin-scaffolder-backend';
 import { Router } from 'express';
 import { PluginEnvironment } from '../types';
-import createCatalogEventBasedProviders from './catalogEventBasedProviders';
+import { DemoEventBasedEntityProvider } from './DemoEventBasedEntityProvider';
 
 export default async function createPlugin(
   env: PluginEnvironment,
 ): Promise<Router> {
-  const providers = await createCatalogEventBasedProviders(env);
+  const { eventBroker, logger } = env;
+
   const builder = await CatalogBuilder.create(env);
   builder.addProcessor(new ScaffolderEntitiesProcessor());
-  env.eventBroker.subscribe(providers);
-  builder.addEntityProvider(providers);
+
+  const demoProvider = new DemoEventBasedEntityProvider(logger, ['example']);
+  eventBroker.subscribe(demoProvider);
+  builder.addEntityProvider(demoProvider);
+
   const { processingEngine, router } = await builder.build();
   await processingEngine.start();
   return router;