scaffolder: rename and move /preview -> /edit

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2022-04-01 14:10:46 +02:00
parent 6331ec1ebc
commit 8fad3b6ef5
5 changed files with 15 additions and 8 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-scaffolder': minor
---
The Template Preview page has been renamed to Template Editor, and is not available at the `/edit` path instead. There is a redirect in place from `/preview`.
+6 -4
View File
@@ -15,7 +15,7 @@
*/
import React, { ComponentType } from 'react';
import { Routes, Route, useOutlet } from 'react-router';
import { Routes, Route, useOutlet, Navigate } from 'react-router';
import { Entity } from '@backstage/catalog-model';
import { TemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common';
import { ScaffolderPage } from './ScaffolderPage';
@@ -23,7 +23,7 @@ import { TemplatePage } from './TemplatePage';
import { TaskPage } from './TaskPage';
import { ActionsPage } from './ActionsPage';
import { SecretsContextProvider } from './secrets/SecretsContext';
import { TemplatePreviewPage } from './TemplatePreviewPage';
import { TemplateEditorPage } from './TemplateEditorPage';
import {
FieldExtensionOptions,
@@ -116,16 +116,18 @@ export const Router = (props: RouterProps) => {
<Route path="/tasks/:taskId" element={<TaskPageElement />} />
<Route path="/actions" element={<ActionsPage />} />
<Route
path="/preview"
path="/edit"
element={
<SecretsContextProvider>
<TemplatePreviewPage
<TemplateEditorPage
defaultPreviewTemplate={defaultPreviewTemplate}
customFieldExtensions={fieldExtensions}
/>
</SecretsContextProvider>
}
/>
<Route path="preview" element={<Navigate to="../edit" />} />
</Routes>
);
};
@@ -85,7 +85,7 @@ export function ScaffolderPageContextMenu(
>
<MenuList>
{showEditor && (
<MenuItem onClick={() => navigate(`${pageLink()}/preview`)}>
<MenuItem onClick={() => navigate(`${pageLink()}/edit`)}>
<ListItemIcon>
<Edit fontSize="small" />
</ListItemIcon>
@@ -92,7 +92,7 @@ const useStyles = makeStyles({
},
});
export const TemplatePreviewPage = ({
export const TemplateEditorPage = ({
defaultPreviewTemplate = EXAMPLE_TEMPLATE_PARAMS_YAML,
customFieldExtensions = [],
}: {
@@ -200,7 +200,7 @@ export const TemplatePreviewPage = ({
return (
<Page themeId="home">
<Header
title="Template Preview"
title="Template Editor"
subtitle="Preview your template parameter UI"
/>
<Content>
@@ -13,4 +13,4 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export { TemplatePreviewPage } from './TemplatePreviewPage';
export { TemplateEditorPage } from './TemplateEditorPage';