diff --git a/.changeset/moody-sheep-marry.md b/.changeset/moody-sheep-marry.md new file mode 100644 index 0000000000..73f037db32 --- /dev/null +++ b/.changeset/moody-sheep-marry.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': minor +--- + +The Template Preview page has been renamed to Template Editor, and is not available at the `/edit` path instead. There is a redirect in place from `/preview`. diff --git a/plugins/scaffolder/src/components/Router.tsx b/plugins/scaffolder/src/components/Router.tsx index c3efce1020..3ab3b03dd8 100644 --- a/plugins/scaffolder/src/components/Router.tsx +++ b/plugins/scaffolder/src/components/Router.tsx @@ -15,7 +15,7 @@ */ import React, { ComponentType } from 'react'; -import { Routes, Route, useOutlet } from 'react-router'; +import { Routes, Route, useOutlet, Navigate } from 'react-router'; import { Entity } from '@backstage/catalog-model'; import { TemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common'; import { ScaffolderPage } from './ScaffolderPage'; @@ -23,7 +23,7 @@ import { TemplatePage } from './TemplatePage'; import { TaskPage } from './TaskPage'; import { ActionsPage } from './ActionsPage'; import { SecretsContextProvider } from './secrets/SecretsContext'; -import { TemplatePreviewPage } from './TemplatePreviewPage'; +import { TemplateEditorPage } from './TemplateEditorPage'; import { FieldExtensionOptions, @@ -116,16 +116,18 @@ export const Router = (props: RouterProps) => { } /> } /> - } /> + + } /> ); }; diff --git a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx index b79f8917f6..6d9a89cfab 100644 --- a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx +++ b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx @@ -85,7 +85,7 @@ export function ScaffolderPageContextMenu( > {showEditor && ( - navigate(`${pageLink()}/preview`)}> + navigate(`${pageLink()}/edit`)}> diff --git a/plugins/scaffolder/src/components/TemplatePreviewPage/TemplatePreviewPage.tsx b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditorPage.tsx similarity index 99% rename from plugins/scaffolder/src/components/TemplatePreviewPage/TemplatePreviewPage.tsx rename to plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditorPage.tsx index cb4f8e9896..aa04e8d1c6 100644 --- a/plugins/scaffolder/src/components/TemplatePreviewPage/TemplatePreviewPage.tsx +++ b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditorPage.tsx @@ -92,7 +92,7 @@ const useStyles = makeStyles({ }, }); -export const TemplatePreviewPage = ({ +export const TemplateEditorPage = ({ defaultPreviewTemplate = EXAMPLE_TEMPLATE_PARAMS_YAML, customFieldExtensions = [], }: { @@ -200,7 +200,7 @@ export const TemplatePreviewPage = ({ return (
diff --git a/plugins/scaffolder/src/components/TemplatePreviewPage/index.ts b/plugins/scaffolder/src/components/TemplateEditorPage/index.ts similarity index 90% rename from plugins/scaffolder/src/components/TemplatePreviewPage/index.ts rename to plugins/scaffolder/src/components/TemplateEditorPage/index.ts index cdf7bd1e82..506ff08f24 100644 --- a/plugins/scaffolder/src/components/TemplatePreviewPage/index.ts +++ b/plugins/scaffolder/src/components/TemplateEditorPage/index.ts @@ -13,4 +13,4 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -export { TemplatePreviewPage } from './TemplatePreviewPage'; +export { TemplateEditorPage } from './TemplateEditorPage';