comments & plugin fixed

Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
This commit is contained in:
Deepankumar Loganathan
2023-11-09 14:07:06 +01:00
committed by blam
parent bfa0c5ceaa
commit 8cc5835c38
2 changed files with 5 additions and 16 deletions
+5 -1
View File
@@ -19,12 +19,16 @@ import {
} from '@backstage/plugin-azure-sites-backend';
import { Router } from 'express';
import { PluginEnvironment } from '../types';
import { CatalogClient } from '@backstage/catalog-client';
export default async function createPlugin(
env: PluginEnvironment,
): Promise<Router> {
const catalogApi = new CatalogClient({ discoveryApi: env.discovery });
return await createRouter({
...env,
logger: env.logger,
permissions: env.permissions,
azureSitesApi: AzureSitesApi.fromConfig(env.config),
catalogApi,
});
}
@@ -19,7 +19,6 @@ import { createRouter } from '@backstage/plugin-permission-backend';
import {
AuthorizeResult,
PolicyDecision,
isPermission,
} from '@backstage/plugin-permission-common';
import {
PermissionPolicy,
@@ -31,11 +30,6 @@ import {
} from '@backstage/plugin-playlist-backend';
import { Router } from 'express';
import { PluginEnvironment } from '../types';
import { azureSitesActionPermission } from '@backstage/plugin-azure-sites-common';
import {
catalogConditions,
createCatalogConditionalDecision,
} from '@backstage/plugin-catalog-backend/alpha';
class ExamplePermissionPolicy implements PermissionPolicy {
private playlistPermissionPolicy = new DefaultPlaylistPermissionPolicy();
@@ -48,15 +42,6 @@ class ExamplePermissionPolicy implements PermissionPolicy {
return this.playlistPermissionPolicy.handle(request, user);
}
if (isPermission(request.permission, azureSitesActionPermission)) {
return createCatalogConditionalDecision(
request.permission,
catalogConditions.isEntityOwner({
claims: user?.identity.ownershipEntityRefs ?? [],
}),
);
}
return {
result: AuthorizeResult.ALLOW,
};