feat(plugins/pagerduty): refactor PagerDutyClient.fromConfig to accept second argument of ClientApiDependencies

Signed-off-by: Alec Jacobs <cajacobs5401@gmail.com>

plugins/pagerduty/src/api/client.ts

@@ -22,16 +22,12 @@ import {
   ServiceResponse,
   IncidentsResponse,
   OnCallsResponse,
+  ClientApiDependencies,
   ClientApiConfig,
   RequestOptions,
   ChangeEventsResponse,
 } from './types';
-import {
-  createApiRef,
-  DiscoveryApi,
-  ConfigApi,
-  FetchApi,
-} from '@backstage/core-plugin-api';
+import { createApiRef, ConfigApi } from '@backstage/core-plugin-api';
 import { NotFoundError } from '@backstage/errors';
 
 export class UnauthorizedError extends Error {}
@@ -46,12 +42,12 @@ const commonGetServiceParams =
 export class PagerDutyClient implements PagerDutyApi {
   static fromConfig(
     configApi: ConfigApi,
-    discoveryApi: DiscoveryApi,
-    fetchApi: FetchApi,
+    { discoveryApi, fetchApi }: ClientApiDependencies,
   ) {
     const eventsBaseUrl: string =
       configApi.getOptionalString('pagerDuty.eventsBaseUrl') ??
       'https://events.pagerduty.com/v2';
+
     return new PagerDutyClient({
       eventsBaseUrl,
       discoveryApi,

plugins/pagerduty/src/plugin.ts

@@ -39,7 +39,7 @@ export const pagerDutyPlugin = createPlugin({
         fetchApi: fetchApiRef,
       },
       factory: ({ configApi, discoveryApi, fetchApi }) =>
-        PagerDutyClient.fromConfig(configApi, discoveryApi, fetchApi),
+        PagerDutyClient.fromConfig(configApi, { discoveryApi, fetchApi }),
     }),
   ],
 });