cli,frontend-app-api: cleanup

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

packages/app-next/app-config.yaml

@@ -1,8 +1,6 @@
 app:
   experimental:
-    # packages: 'all' # ✨
-    packages: 'all'
-
+    packages: 'all' # ✨
 
   # scmAuthExtension: >-
   #   createScmAuthExtension({

packages/cli/package.json

@@ -133,7 +133,6 @@
     "webpack": "^5.70.0",
     "webpack-dev-server": "^4.7.3",
     "webpack-node-externals": "^3.0.0",
-    "webpack-virtual-modules": "^0.5.0",
     "yaml": "^2.0.0",
     "yml-loader": "^2.1.0",
     "yn": "^4.0.0",

packages/cli/src/lib/bundler/server.ts

@@ -109,7 +109,6 @@ export async function serveBundle(options: ServeOptions) {
   }
 
   const { frontendConfig, fullConfig } = cliConfig;
-  // TODO: proper
   const url = resolveBaseUrl(frontendConfig);
 
   const host =
@@ -133,7 +132,6 @@ export async function serveBundle(options: ServeOptions) {
     isDev: true,
     baseUrl: url,
     frontendConfig,
-    frontendAppConfigs: [],
     getFrontendAppConfigs: () => {
       return latestFrontendAppConfigs;
     },

packages/cli/src/lib/bundler/types.ts

@@ -23,7 +23,6 @@ export type BundlingOptions = {
   isDev: boolean;
   frontendConfig: Config;
   getFrontendAppConfigs(): AppConfig[];
-  frontendAppConfigs: AppConfig[];
   baseUrl: URL;
   parallelism?: number;
   additionalEntryPoints?: string[];

packages/frontend-app-api/src/createApp.tsx

@@ -32,7 +32,7 @@ import {
 } from './wiring/parameters';
 import { RoutingProvider } from './routing/RoutingContext';
 import { RouteRef } from '@backstage/core-plugin-api';
-import { getAvailablePlugins } from './discover';
+import { getAvailablePlugins } from './wiring/discovery';
 
 /** @public */
 export function createApp(options: { plugins: BackstagePlugin[] }): {

packages/frontend-app-api/src/discover/discover-plugins.d.ts

@@ -1,22 +0,0 @@
-/*
- * Copyright 2023 The Backstage Authors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-declare module '__backstage-autodetected-plugins__' {
-  type DetectedModule = {
-    name: string;
-    module: Record<string, any>;
-  };
-  const modules: Array<{ name: string; module: Record<string, any> }>;
-}

yarn.lock

@@ -3882,7 +3882,6 @@ __metadata:
     webpack: ^5.70.0
     webpack-dev-server: ^4.7.3
     webpack-node-externals: ^3.0.0
-    webpack-virtual-modules: ^0.5.0
     yaml: ^2.0.0
     yml-loader: ^2.1.0
     yn: ^4.0.0
@@ -42820,13 +42819,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"webpack-virtual-modules@npm:^0.5.0":
-  version: 0.5.0
-  resolution: "webpack-virtual-modules@npm:0.5.0"
-  checksum: 22b59257b55c89d11ae295b588b683ee9fdf3aeb591bc7b6f88ac1d69cb63f4fcb507666ea986866dfae161a1fa534ad6fb4e2ea91bbcd0a6d454368d7d4c64b
-  languageName: node
-  linkType: hard
-
 "webpack@npm:^5, webpack@npm:^5.70.0":
   version: 5.88.2
   resolution: "webpack@npm:5.88.2"