packages/core: add missing types for apis

packages/core/src/api/apis/definitions/alert.ts

@@ -29,7 +29,7 @@ export type AlertApi = {
   /**
    * Post an alert for handling by the application.
    */
-  post(alert: AlertMessage);
+  post(alert: AlertMessage): void;
 };
 
 export const alertApiRef = new ApiRef<AlertApi>({

packages/core/src/api/apis/definitions/error.ts

@@ -53,7 +53,7 @@ export type ErrorApi = {
   /**
    * Post an error for handling by the application.
    */
-  post(error: Error, context?: ErrorContext);
+  post(error: Error, context?: ErrorContext): void;
 };
 
 export const errorApiRef = new ApiRef<ErrorApi>({

packages/core/src/api/app/FeatureFlags.test.tsx

@@ -15,7 +15,10 @@
  */
 
 import { FeatureFlags as FeatureFlagsImpl } from './FeatureFlags';
-import { FeatureFlagState } from 'api/apis/definitions/featureFlags';
+import {
+  FeatureFlagState,
+  FeatureFlagsApi,
+} from 'api/apis/definitions/featureFlags';
 
 describe('FeatureFlags', () => {
   beforeEach(() => {
@@ -23,7 +26,7 @@ describe('FeatureFlags', () => {
   });
 
   describe('#getFlags', () => {
-    let featureFlags;
+    let featureFlags: FeatureFlagsApi;
 
     beforeEach(() => {
       featureFlags = new FeatureFlagsImpl();
@@ -121,7 +124,7 @@ describe('FeatureFlags', () => {
   });
 
   describe('#getRegisteredFlags', () => {
-    let featureFlags;
+    let featureFlags: FeatureFlagsApi;
 
     beforeEach(() => {
       featureFlags = new FeatureFlagsImpl();
@@ -146,7 +149,7 @@ describe('FeatureFlags', () => {
     });
 
     it('should get the correct values', () => {
-      const getByName = name =>
+      const getByName = (name: string) =>
         featureFlags.getRegisteredFlags().find(flag => flag.name === name);
 
       expect(getByName('registered-flag-0')).toBeUndefined();