paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 43 Packages Projects Releases Wiki Activity

fix: remove tautological assertion in burst length test

Browse Source 
Replace the self-referencing callCount assertion with a concrete
expected value of 3, derived from the mocked time progression.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
This commit is contained in:
Fredrik Adelöw
2026-03-10 20:12:49 +01:00
parent cbcc344945
commit 85ec4d7314
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog-backend-module-incremental-ingestion/src/engine/IncrementalIngestionEngine.test.ts
+5 -4
View File
@@ -110,11 +110,12 @@ describe('IncrementalIngestionEngine - Burst Length', () => {
const result = await engine.ingestOneBurst('test-ingestion', signal);
// After 3 calls: time is 1120, elapsed is 120 > 100ms burst length
// The burst check happens after the 3rd call, so we get 3 calls
// Call 1: time=1040, elapsed=40 < 100 → continue
// Call 2: time=1080, elapsed=80 < 100 → continue
// Call 3: time=1120, elapsed=120 > 100 → stop
expect(result).toBe(false);
expect(mockProvider.next).toHaveBeenCalledTimes(callCount);
expect(callCount).toBeGreaterThan(1);
expect(mockProvider.next).toHaveBeenCalledTimes(3);
expect(callCount).toBe(3);
});
it('should complete burst normally when provider returns done before burst length', async () => {