Added a oidc provider test

plugins/auth-backend/package.json

@@ -60,13 +60,15 @@
     "@types/cookie-parser": "^1.4.2",
     "@types/express-session": "^1.17.2",
     "@types/jwt-decode": "2.2.1",
+    "@types/nock": "^11.1.0",
     "@types/openid-client": "^3.7.0",
     "@types/passport": "^1.0.3",
     "@types/passport-github2": "^1.2.4",
     "@types/passport-google-oauth20": "^2.0.3",
     "@types/passport-microsoft": "^0.0.0",
     "@types/passport-saml": "^1.1.2",
-    "msw": "^0.21.2"
+    "msw": "^0.21.2",
+    "nock": "^13.0.5"
   },
   "files": [
     "dist",

plugins/auth-backend/src/providers/oidc/provider.test.ts

@@ -0,0 +1,60 @@
+/*
+ * Copyright 2020 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import nock from 'nock';
+import { ClientMetadata, IssuerMetadata } from 'openid-client';
+import { OidcAuthProvider } from './provider';
+
+const issuerMetadata = {
+  issuer: 'https://oidc.test',
+  authorization_endpoint: 'https://oidc.test/as/authorization.oauth2',
+  token_endpoint: 'https://oidc.test/as/token.oauth2',
+  revocation_endpoint: 'https://oidc.test/as/revoke_token.oauth2',
+  userinfo_endpoint: 'https://oidc.test/idp/userinfo.openid',
+  introspection_endpoint: 'https://oidc.test/as/introspect.oauth2',
+  jwks_uri: 'https://oidc.test/pf/JWKS',
+  scopes_supported: ['openid'],
+  claims_supported: ['email'],
+  response_types_supported: ['code'],
+  id_token_signing_alg_values_supported: ['RS256', 'RS512'],
+  token_endpoint_auth_signing_alg_values_supported: ['RS256', 'RS512'],
+  request_object_signing_alg_values_supported: ['RS256', 'RS512'],
+};
+
+const clientMetadata = {
+  callbackUrl: 'https://oidc.test/callback',
+  clientId: 'testclientid',
+  clientSecret: 'testclientsecret',
+  metadataUrl: 'https://oidc.test/.well-known/openid-configuration',
+};
+
+describe('OidcAuthProvider', () => {
+  it('hit the metadataurl', async () => {
+    const scope = nock('https://oidc.test')
+      .get('/.well-known/openid-configuration')
+      .reply(200, issuerMetadata);
+    const provider = new OidcAuthProvider(clientMetadata);
+    const strategy = ((await provider._strategy) as any) as {
+      _client: ClientMetadata;
+      _issuer: IssuerMetadata;
+    };
+    // Assert that the expected request to the metadaurl was made.
+    expect(scope.isDone()).toBeTruthy();
+    const { _client, _issuer } = strategy;
+    expect(_client.client_id).toBe(clientMetadata.clientId);
+    expect(_issuer.token_endpoint).toBe(issuerMetadata.token_endpoint);
+  });
+});

plugins/auth-backend/src/providers/oidc/provider.ts

@@ -51,7 +51,7 @@ export type OidcAuthProviderOptions = OAuthProviderOptions & {
 };
 
 export class OidcAuthProvider implements OAuthHandlers {
-  private readonly _strategy: Promise<OidcStrategy<UserinfoResponse, Client>>;
+  readonly _strategy: Promise<OidcStrategy<UserinfoResponse, Client>>;
 
   constructor(options: OidcAuthProviderOptions) {
     this._strategy = this.setupStrategy(options);

yarn.lock

@@ -5521,6 +5521,13 @@
   dependencies:
     "@types/node" "*"
 
+"@types/nock@^11.1.0":
+  version "11.1.0"
+  resolved "https://registry.npmjs.org/@types/nock/-/nock-11.1.0.tgz#0a8c1056a31ba32a959843abccf99626dd90a538"
+  integrity sha512-jI/ewavBQ7X5178262JQR0ewicPAcJhXS/iFaNJl0VHLfyosZ/kwSrsa6VNQNSO8i9d8SqdRgOtZSOKJ/+iNMw==
+  dependencies:
+    nock "*"
+
 "@types/node-fetch@2.5.7", "@types/node-fetch@^2.5.4":
   version "2.5.7"
   resolved "https://registry.npmjs.org/@types/node-fetch/-/node-fetch-2.5.7.tgz#20a2afffa882ab04d44ca786449a276f9f6bbf3c"
@@ -17139,6 +17146,16 @@ no-case@^3.0.3:
     lower-case "^2.0.1"
     tslib "^1.10.0"
 
+nock@*, nock@^13.0.5:
+  version "13.0.5"
+  resolved "https://registry.npmjs.org/nock/-/nock-13.0.5.tgz#a618c6f86372cb79fac04ca9a2d1e4baccdb2414"
+  integrity sha512-1ILZl0zfFm2G4TIeJFW0iHknxr2NyA+aGCMTjDVUsBY4CkMRispF1pfIYkTRdAR/3Bg+UzdEuK0B6HczMQZcCg==
+  dependencies:
+    debug "^4.1.0"
+    json-stringify-safe "^5.0.1"
+    lodash.set "^4.3.2"
+    propagate "^2.0.0"
+
 node-addon-api@2.0.0:
   version "2.0.0"
   resolved "https://registry.npmjs.org/node-addon-api/-/node-addon-api-2.0.0.tgz#f9afb8d777a91525244b01775ea0ddbe1125483b"
@@ -19385,6 +19402,11 @@ prop-types@^15.5.10, prop-types@^15.5.8, prop-types@^15.6.0, prop-types@^15.6.1,
     object-assign "^4.1.1"
     react-is "^16.8.1"
 
+propagate@^2.0.0:
+  version "2.0.1"
+  resolved "https://registry.npmjs.org/propagate/-/propagate-2.0.1.tgz#40cdedab18085c792334e64f0ac17256d38f9a45"
+  integrity sha512-vGrhOavPSTz4QVNuBNdcNXePNdNMaO1xj9yBeH1ScQPjk/rhg9sSlCXPhMkFuaNNW/syTvYqsnbIJxMBfRbbag==
+
 property-expr@^2.0.2:
   version "2.0.2"
   resolved "https://registry.npmjs.org/property-expr/-/property-expr-2.0.2.tgz#fff2a43919135553a3bc2fdd94bdb841965b2330"