Remove description/tag from default columns for Location entity

Signed-off-by: Brian Forbis <bforbis@athenahealth.com>
This commit is contained in:
Brian Forbis
2024-09-14 13:52:01 -04:00
parent 8c5c6b8c1a
commit 7853e70109
2 changed files with 14 additions and 14 deletions
@@ -222,14 +222,7 @@ describe('CatalogTable component', () => {
},
{
kind: 'location',
expectedColumns: [
'Name',
'Type',
'Targets',
'Description',
'Tags',
'Actions',
],
expectedColumns: ['Name', 'Type', 'Targets', 'Actions'],
},
{
kind: 'resource',
@@ -31,11 +31,13 @@ export const defaultCatalogTableColumnsFunc: CatalogTableColumnsFunc = ({
columnFactories.createTitleColumn({ hidden: true }),
columnFactories.createNameColumn({ defaultKind: filters.kind?.value }),
...createEntitySpecificColumns(),
columnFactories.createMetadataDescriptionColumn(),
columnFactories.createTagsColumn(),
];
function createEntitySpecificColumns(): TableColumn<CatalogTableRow>[] {
const descriptionTagColumns = [
columnFactories.createMetadataDescriptionColumn(),
columnFactories.createTagsColumn(),
];
const baseColumns = [
columnFactories.createSystemColumn(),
columnFactories.createOwnerColumn(),
@@ -44,14 +46,15 @@ export const defaultCatalogTableColumnsFunc: CatalogTableColumnsFunc = ({
];
switch (filters.kind?.value) {
case 'user':
return [];
return [...descriptionTagColumns];
case 'domain':
case 'system':
return [columnFactories.createOwnerColumn()];
return [columnFactories.createOwnerColumn(), ...descriptionTagColumns];
case 'group':
case 'template':
return [
columnFactories.createSpecTypeColumn({ hidden: !showTypeColumn }),
...descriptionTagColumns,
];
case 'location':
return [
@@ -60,8 +63,12 @@ export const defaultCatalogTableColumnsFunc: CatalogTableColumnsFunc = ({
];
default:
return entities.every(entity => entity.metadata.namespace === 'default')
? baseColumns
: [...baseColumns, columnFactories.createNamespaceColumn()];
? [...baseColumns, ...descriptionTagColumns]
: [
...baseColumns,
columnFactories.createNamespaceColumn(),
...descriptionTagColumns,
];
}
}
};