changes based upon feedback from maintainers
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
---
|
||||
'@backstage/plugin-jenkins': minor
|
||||
'@backstage/plugin-jenkins': patch
|
||||
---
|
||||
|
||||
Extend EntityJenkinsContent to receive columns as prop
|
||||
|
||||
@@ -57,6 +57,7 @@ export interface Build {
|
||||
status: string; // == building ? 'running' : result,
|
||||
}
|
||||
|
||||
/** @public */
|
||||
export interface Project {
|
||||
// standard Jenkins
|
||||
lastBuild: Build;
|
||||
|
||||
@@ -14,5 +14,3 @@
|
||||
* limitations under the License.
|
||||
*/
|
||||
export { CITable } from './CITable';
|
||||
export { columnFactories as ciTableColumnFactories } from './columns';
|
||||
export { defaultCITableColumns } from './presets';
|
||||
|
||||
@@ -33,11 +33,7 @@ export const isJenkinsAvailable = (entity: Entity) =>
|
||||
Boolean(entity.metadata.annotations?.[JENKINS_ANNOTATION]) ||
|
||||
Boolean(entity.metadata.annotations?.[LEGACY_JENKINS_ANNOTATION]);
|
||||
|
||||
type Props = {
|
||||
columns?: TableColumn<Project>[];
|
||||
};
|
||||
|
||||
export const Router = (props: Props) => {
|
||||
export const Router = (props: { columns?: TableColumn<Project>[] }) => {
|
||||
const { entity } = useEntity();
|
||||
|
||||
if (!isJenkinsAvailable(entity)) {
|
||||
|
||||
@@ -34,7 +34,3 @@ export {
|
||||
} from './components/Router';
|
||||
export { JENKINS_ANNOTATION, LEGACY_JENKINS_ANNOTATION } from './constants';
|
||||
export * from './api';
|
||||
export {
|
||||
ciTableColumnFactories,
|
||||
defaultCITableColumns,
|
||||
} from './components/BuildsPage/lib/CITable';
|
||||
|
||||
Reference in New Issue
Block a user