Merge pull request #31343 from backstage/bui-fix-header

Fix BUI Header hrefs

.changeset/few-weeks-create.md

@@ -0,0 +1,5 @@
+---
+'@backstage/ui': patch
+---
+
+Making href mandatory in tabs that are part of a Header component

packages/ui/report.api.md

@@ -1038,7 +1038,7 @@ export interface HeaderProps {
 // @public
 export interface HeaderTab {
   // (undocumented)
-  href?: string;
+  href: string;
   // (undocumented)
   id: string;
   // (undocumented)

packages/ui/src/components/Header/types.ts

@@ -39,7 +39,7 @@ export interface HeaderProps {
 export interface HeaderTab {
   id: string;
   label: string;
-  href?: string;
+  href: string;
   /**
    * Strategy for matching the current route to determine if this tab should be active.
    * - 'exact': Tab href must exactly match the current pathname (default)

packages/ui/src/components/HeaderPage/HeaderPage.stories.tsx

@@ -44,22 +44,27 @@ const tabs: HeaderTab[] = [
   {
     id: 'overview',
     label: 'Overview',
+    href: '/overview',
   },
   {
     id: 'checks',
     label: 'Checks',
+    href: '/checks',
   },
   {
     id: 'tracks',
     label: 'Tracks',
+    href: '/tracks',
   },
   {
     id: 'campaigns',
     label: 'Campaigns',
+    href: '/campaigns',
   },
   {
     id: 'integrations',
     label: 'Integrations',
+    href: '/integrations',
   },
 ];