PR feedback, reverting unnecessary changes and updating changeset

Signed-off-by: Andrew Ochsner <andrew.ochsner@cognizant.com>
This commit is contained in:
Andrew Ochsner
2023-05-10 15:58:58 -05:00
parent 696150c39a
commit 7514271a80
3 changed files with 4 additions and 9 deletions
-5
View File
@@ -1,5 +0,0 @@
---
'@backstage/plugin-catalog-backend-module-aws': patch
---
Upgrading from v2 `aws-sdk` to v3
+1 -1
View File
@@ -1,6 +1,6 @@
---
'@backstage/plugin-events-backend-module-aws-sqs': patch
'@backstage/plugin-catalog-backend-module-aws': patch
'@backstage/plugin-catalog-backend-module-aws': minor
'@backstage/integration-aws-node': patch
'@backstage/plugin-kubernetes-backend': patch
'@backstage/backend-common': patch
@@ -51,9 +51,9 @@ const ORGANIZATION_ANNOTATION = 'amazonaws.com/organization-id';
*/
export class AwsOrganizationCloudAccountProcessor implements CatalogProcessor {
private readonly organizations: Organizations;
private readonly logger?: Logger;
private readonly logger: Logger;
static async fromConfig(config: Config, options: { logger?: Logger }) {
static async fromConfig(config: Config, options: { logger: Logger }) {
const c = config.getOptionalConfig('catalog.processors.awsOrganization');
const orgConfig = c ? readAwsOrganizationConfig(c) : undefined;
const awsCredentialsManager =
@@ -69,7 +69,7 @@ export class AwsOrganizationCloudAccountProcessor implements CatalogProcessor {
private constructor(
private readonly credProvider: AwsCredentialProvider,
logger?: Logger,
logger: Logger,
) {
this.logger = logger?.child({
target: this.getProcessorName(),