paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 31 Packages Projects Releases Wiki Activity

Fix simple review comments

Browse Source 
Signed-off-by: David Festal <dfestal@redhat.com>
This commit is contained in:
David Festal
2025-04-08 21:36:46 +02:00
parent 3bee3c3bcf
commit 7452c175b7
4 changed files with 92 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/large-phones-tie.md
+1 -1
View File
@@ -1,6 +1,6 @@
---
'@backstage/backend-dynamic-feature-service': patch
'@backstage/frontend-dynamic-feature-loader': patch
'@backstage/frontend-dynamic-feature-loader': minor
'@backstage/frontend-defaults': patch
---
packages/frontend-dynamic-feature-loader/README.md
+1 -1
View File
@@ -9,7 +9,7 @@ The frontend feature loader provided in this package works hand-in-hand with the
- To enable this loader, you should:
- Enable the backend dynamic features in your backend application, as explained in `packages/backend-dynamic-feature-service/README.md#how-it-works`
- Enable the backend dynamic features in your backend application, as explained in the [`backend-dynamic-feature-service` README.md file](../backend-dynamic-feature-service/README.md#how-it-works)
- Add the frontend feature loader to the list of features when creating the frontend application:
```typescript
packages/frontend-dynamic-feature-loader/package.json
+8 -7
View File
@@ -1,6 +1,6 @@
{
"name": "@backstage/frontend-dynamic-feature-loader",
"version": "0.0.1-next.0",
"version": "0.0.0",
"backstage": {
"role": "web-library"
},
@@ -36,13 +36,14 @@
"@backstage/core-app-api": "workspace:^",
"@backstage/frontend-plugin-api": "workspace:^",
"@module-federation/enhanced": "^0.9.0",
"@module-federation/runtime": "^0.9.0",
"@module-federation/sdk": "^0.9.0",
"cross-fetch": "^4.0.0"
"cross-fetch": "^4.0.0",
"uri-template": "^2.0.0"
},
"devDependencies": {
"@backstage/cli": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@module-federation/runtime": "^0.9.0",
"@testing-library/jest-dom": "^6.0.0",
"@testing-library/react": "^16.0.0",
"@types/react": "^18.0.0",
@@ -52,10 +53,10 @@
"react-router-dom": "^6.3.0"
},
"peerDependencies": {
"@types/react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-router-dom": "6.0.0-beta.0 || ^6.3.0"
"@types/react": "^17.0.0 || ^18.0.0",
"react": "^17.0.0 || ^18.0.0",
"react-dom": "^17.0.0 || ^18.0.0",
"react-router-dom": "^6.3.0"
},
"peerDependenciesMeta": {
"@types/react": {
yarn.lock
+82 -125
View File
@@ -4750,11 +4750,12 @@ __metadata:
react: "npm:^18.0.2"
react-dom: "npm:^18.0.2"
react-router-dom: "npm:^6.3.0"
uri-template: "npm:^2.0.0"
peerDependencies:
"@types/react": ^16.13.1 || ^17.0.0 || ^18.0.0
react: ^16.13.1 || ^17.0.0 || ^18.0.0
react-dom: ^16.13.1 || ^17.0.0 || ^18.0.0
react-router-dom: 6.0.0-beta.0 || ^6.3.0
"@types/react": ^17.0.0 || ^18.0.0
react: ^17.0.0 || ^18.0.0
react-dom: ^17.0.0 || ^18.0.0
react-router-dom: ^6.3.0
peerDependenciesMeta:
"@types/react":
optional: true
@@ -12045,39 +12046,39 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/bridge-react-webpack-plugin@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/bridge-react-webpack-plugin@npm:0.9.0"
"@module-federation/bridge-react-webpack-plugin@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/bridge-react-webpack-plugin@npm:0.9.1"
dependencies:
"@module-federation/sdk": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.1"
"@types/semver": "npm:7.5.8"
semver: "npm:7.6.3"
checksum: 10/234b022407b1d84790aecc32f2b825ad22c7ebfa541914367270f307b0962194511460d6ace0b7c76bcf9aaf6dc4d09c3021f4cb73ec6568412d31023bf9c93f
checksum: 10/4ff197741b1bdccf8f9e2236781e5ce3ef434e4207c5462b4b95b044c4c57a3ab3dd4dce48490d9fde5bd06fb855b9918841c7d04306726ee224d3e288074091
languageName: node
linkType: hard
"@module-federation/data-prefetch@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/data-prefetch@npm:0.9.0"
"@module-federation/data-prefetch@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/data-prefetch@npm:0.9.1"
dependencies:
"@module-federation/runtime": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.0"
"@module-federation/runtime": "npm:0.9.1"
"@module-federation/sdk": "npm:0.9.1"
fs-extra: "npm:9.1.0"
peerDependencies:
react: ">=16.9.0"
react-dom: ">=16.9.0"
checksum: 10/d8cfef2e3427326048e17a686e3d2df8df7f6913170ddd03fff93af29bd03e68ab26f8b2587bec99357e2fb3fbed457f81e3ba6e8af98deacd744850869c1516
checksum: 10/a3c0e8d77f4d06e3851d041175ef3f55d47ff4069a526b9ac773c8aba71a520a0490653c87cdcf3761e96f9eb9ea16d45026f3aafdf0851c34ff4db6d71ec113
languageName: node
linkType: hard
"@module-federation/dts-plugin@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/dts-plugin@npm:0.9.0"
"@module-federation/dts-plugin@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/dts-plugin@npm:0.9.1"
dependencies:
"@module-federation/error-codes": "npm:0.9.0"
"@module-federation/managers": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.0"
"@module-federation/third-party-dts-extractor": "npm:0.9.0"
"@module-federation/error-codes": "npm:0.9.1"
"@module-federation/managers": "npm:0.9.1"
"@module-federation/sdk": "npm:0.9.1"
"@module-federation/third-party-dts-extractor": "npm:0.9.1"
adm-zip: "npm:^0.5.10"
ansi-colors: "npm:^4.1.3"
axios: "npm:^1.7.4"
@@ -12096,24 +12097,24 @@ __metadata:
peerDependenciesMeta:
vue-tsc:
optional: true
checksum: 10/539d277dd7c769ec9edde394fe3e9dddb38533c6fde0ac0fef0346d1229795a1b2199c4cc73e457b0ac2480c3548814e01d9fa47e12327fe97e3f6486300002d
checksum: 10/e9fd11b150456f2621636587d181f6456fe5cd60a0720843fe1310e350c3ff8ebef02ea87d1bf40dc04a4b4cd65cfb2e9007ca1c20e4e5664142b7c670c4a57d
languageName: node
linkType: hard
"@module-federation/enhanced@npm:^0.9.0":
version: 0.9.0
resolution: "@module-federation/enhanced@npm:0.9.0"
version: 0.9.1
resolution: "@module-federation/enhanced@npm:0.9.1"
dependencies:
"@module-federation/bridge-react-webpack-plugin": "npm:0.9.0"
"@module-federation/data-prefetch": "npm:0.9.0"
"@module-federation/dts-plugin": "npm:0.9.0"
"@module-federation/error-codes": "npm:0.9.0"
"@module-federation/inject-external-runtime-core-plugin": "npm:0.9.0"
"@module-federation/managers": "npm:0.9.0"
"@module-federation/manifest": "npm:0.9.0"
"@module-federation/rspack": "npm:0.9.0"
"@module-federation/runtime-tools": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.0"
"@module-federation/bridge-react-webpack-plugin": "npm:0.9.1"
"@module-federation/data-prefetch": "npm:0.9.1"
"@module-federation/dts-plugin": "npm:0.9.1"
"@module-federation/error-codes": "npm:0.9.1"
"@module-federation/inject-external-runtime-core-plugin": "npm:0.9.1"
"@module-federation/managers": "npm:0.9.1"
"@module-federation/manifest": "npm:0.9.1"
"@module-federation/rspack": "npm:0.9.1"
"@module-federation/runtime-tools": "npm:0.9.1"
"@module-federation/sdk": "npm:0.9.1"
btoa: "npm:^1.2.1"
upath: "npm:2.0.1"
peerDependencies:
@@ -12127,7 +12128,7 @@ __metadata:
optional: true
webpack:
optional: true
checksum: 10/9cca13bf8118ed3e11a54adb1006dc5a55437c0140d1edff3a8969c0ed90c07a268f42360e47f90070a32cdfedc340129b3b4e50143ca846c3b8e4ee5880523e
checksum: 10/a7955711f37ba02a18f3570289dfd8fbed30511b82fcf593e56808559cfd49d8852028aa67950db5e45617d0917536d067d85847892e62c20b68ba6ab40e17c4
languageName: node
linkType: hard
@@ -12138,13 +12139,6 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/error-codes@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/error-codes@npm:0.9.0"
checksum: 10/9ebe1bbf3ed61b1d9ec3643d6743884ab5b44290fe5f1cb080ef3f514f1bf9c4cd39309fa3733697030f2468577c6f5159ec0a12d1cb69c7842aaee11159a647
languageName: node
linkType: hard
"@module-federation/error-codes@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/error-codes@npm:0.9.1"
@@ -12152,50 +12146,50 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/inject-external-runtime-core-plugin@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/inject-external-runtime-core-plugin@npm:0.9.0"
"@module-federation/inject-external-runtime-core-plugin@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/inject-external-runtime-core-plugin@npm:0.9.1"
peerDependencies:
"@module-federation/runtime-tools": 0.9.0
checksum: 10/7821cc6bc2cd865ec4b0496c1c53e009611e1bf7571ca6be7e852e79de418df3952ce02b02f7a6773d833638bccbc2b3b853ebd22869a6abdaec717dc5996a8a
"@module-federation/runtime-tools": 0.9.1
checksum: 10/931eef6292c278450fc8cdb017073fa0b721796461eee12a254fc60a88a2f17e91395b12371f2c8b3b25b4056fc2dd2b76d1022e679be7353947c3d797e75ea5
languageName: node
linkType: hard
"@module-federation/managers@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/managers@npm:0.9.0"
"@module-federation/managers@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/managers@npm:0.9.1"
dependencies:
"@module-federation/sdk": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.1"
find-pkg: "npm:2.0.0"
fs-extra: "npm:9.1.0"
checksum: 10/64f8430d6beff7b76e0fe1eaead080bd42a8565bcd3c80b7dcbfba69578c8407ee725785aee847c11e3c3a28c5defb30a39780cb319dca3140c8296c5af0fcfe
checksum: 10/32c1666244ba98644ab6eccdc844415d1aece1c105f6ba2ff17a3836866e7cdb2f61e556cb5a2b506b898ec709951f318d397f4d153efeff377067237968462f
languageName: node
linkType: hard
"@module-federation/manifest@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/manifest@npm:0.9.0"
"@module-federation/manifest@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/manifest@npm:0.9.1"
dependencies:
"@module-federation/dts-plugin": "npm:0.9.0"
"@module-federation/managers": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.0"
"@module-federation/dts-plugin": "npm:0.9.1"
"@module-federation/managers": "npm:0.9.1"
"@module-federation/sdk": "npm:0.9.1"
chalk: "npm:3.0.0"
find-pkg: "npm:2.0.0"
checksum: 10/4902b945845fc3a0d1cffb33227fadc235ed02f62e436bb90dfb4c45b32f508e3692ccc4799733d8439314b8588ef14e597ef11927eea74b6ecd3878924e6ad6
checksum: 10/539b86bd5388296fb35a34c7b732b92788600ab6625d53f11588ad67c3a603ac3c1974541d9cf04db2d24635be1610414c29388e849d96bbb812cad3b1c79425
languageName: node
linkType: hard
"@module-federation/rspack@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/rspack@npm:0.9.0"
"@module-federation/rspack@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/rspack@npm:0.9.1"
dependencies:
"@module-federation/bridge-react-webpack-plugin": "npm:0.9.0"
"@module-federation/dts-plugin": "npm:0.9.0"
"@module-federation/inject-external-runtime-core-plugin": "npm:0.9.0"
"@module-federation/managers": "npm:0.9.0"
"@module-federation/manifest": "npm:0.9.0"
"@module-federation/runtime-tools": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.0"
"@module-federation/bridge-react-webpack-plugin": "npm:0.9.1"
"@module-federation/dts-plugin": "npm:0.9.1"
"@module-federation/inject-external-runtime-core-plugin": "npm:0.9.1"
"@module-federation/managers": "npm:0.9.1"
"@module-federation/manifest": "npm:0.9.1"
"@module-federation/runtime-tools": "npm:0.9.1"
"@module-federation/sdk": "npm:0.9.1"
peerDependencies:
"@rspack/core": ">=0.7"
typescript: ^4.9.0 || ^5.0.0
@@ -12205,7 +12199,7 @@ __metadata:
optional: true
vue-tsc:
optional: true
checksum: 10/3c67889f1f4114ea2f0180f3ba5f2e9cbbc687590d6ec07a20638655b4041a1874bafbe685a93fcb8132c9ad67ace7fe6cde474c70562f8c4fb9af9d9de5aa62
checksum: 10/e6deb7236ccc66d7f0475a09916ec714c9855847bfd3d3ec6cdbee991016a222a22f6ae3fd14d71351d55e22e8949140f37ce9ce79dece5416731c6698726096
languageName: node
linkType: hard
@@ -12219,16 +12213,6 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/runtime-core@npm:0.6.21":
version: 0.6.21
resolution: "@module-federation/runtime-core@npm:0.6.21"
dependencies:
"@module-federation/error-codes": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.0"
checksum: 10/6cff7180b7fd36f37188bc8605861f709ffdb89a1d4600c6d60c6fa4fb44672927f855fbae973e7d0b73f4d1df3408e96af6f616890225d5b4463e48afc2d1f1
languageName: node
linkType: hard
"@module-federation/runtime-core@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/runtime-core@npm:0.9.1"
@@ -12249,13 +12233,13 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/runtime-tools@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/runtime-tools@npm:0.9.0"
"@module-federation/runtime-tools@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/runtime-tools@npm:0.9.1"
dependencies:
"@module-federation/runtime": "npm:0.9.0"
"@module-federation/webpack-bundler-runtime": "npm:0.9.0"
checksum: 10/c92c4614745ded2bbc43edcadb6d661fc392efdc8b0dc72e1f8e34763d3dd326f4b986d4db7ae8e911d6422e5f2cc212d052bd57067e9c4d52a7a572cbdf914c
"@module-federation/runtime": "npm:0.9.1"
"@module-federation/webpack-bundler-runtime": "npm:0.9.1"
checksum: 10/9436e814a4ab72839b8aed1aa097f32cf7d4d49728dd863c9ce6dc4fb149fe49da6dc9cdeb97814f0023cc91489c9aca06cbfdf9fb4e43d20498ab6ee78c95dd
languageName: node
linkType: hard
@@ -12270,18 +12254,7 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/runtime@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/runtime@npm:0.9.0"
dependencies:
"@module-federation/error-codes": "npm:0.9.0"
"@module-federation/runtime-core": "npm:0.6.21"
"@module-federation/sdk": "npm:0.9.0"
checksum: 10/4bed92de413925fa66ffac9f176a72a83b47266830b9a7fe6bbc2e3eea226110455a43d737b1476b314c2a7b38564debe7e1dd6d066a0c6724f8c3be07b2eeef
languageName: node
linkType: hard
"@module-federation/runtime@npm:^0.9.0":
"@module-federation/runtime@npm:0.9.1, @module-federation/runtime@npm:^0.9.0":
version: 0.9.1
resolution: "@module-federation/runtime@npm:0.9.1"
dependencies:
@@ -12299,15 +12272,6 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/sdk@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/sdk@npm:0.9.0"
dependencies:
isomorphic-rslog: "npm:0.0.7"
checksum: 10/031db27afc3ee552dd052f12c8b3d6d967b6590768ebd9b5052c37047453261b9d3bb68e325bdf018f9db88e0a7276bdfeaf82b5cef332f4dd1d5e4a91add0f4
languageName: node
linkType: hard
"@module-federation/sdk@npm:0.9.1, @module-federation/sdk@npm:^0.9.0":
version: 0.9.1
resolution: "@module-federation/sdk@npm:0.9.1"
@@ -12315,14 +12279,14 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/third-party-dts-extractor@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/third-party-dts-extractor@npm:0.9.0"
"@module-federation/third-party-dts-extractor@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/third-party-dts-extractor@npm:0.9.1"
dependencies:
find-pkg: "npm:2.0.0"
fs-extra: "npm:9.1.0"
resolve: "npm:1.22.8"
checksum: 10/accece159cded982499f239b8e7cc7410249ee91b28584652aebb7cc13d07b540939fa9af7ac2609ca20c4b7d2bd113d7120ad535722a3178c404bf19b8ed048
checksum: 10/68c70c79573cd927212d95879aa7b35490519d0ec9f58dd264c9d61e22fea8d452e45a52a94155128d8378e5cdcaecb229707b5b0f4e4c0d53ae96e2fbac366a
languageName: node
linkType: hard
@@ -12336,13 +12300,13 @@ __metadata:
languageName: node
linkType: hard
"@module-federation/webpack-bundler-runtime@npm:0.9.0":
version: 0.9.0
resolution: "@module-federation/webpack-bundler-runtime@npm:0.9.0"
"@module-federation/webpack-bundler-runtime@npm:0.9.1":
version: 0.9.1
resolution: "@module-federation/webpack-bundler-runtime@npm:0.9.1"
dependencies:
"@module-federation/runtime": "npm:0.9.0"
"@module-federation/sdk": "npm:0.9.0"
checksum: 10/8199fa4b5b088e717ac6cd43bd4d2038099d3660568cf79b9e376a395906c40dfe02095f1e1c2c083e3195326a7648dc05ea495701c91eee1fac0e64246cf783
"@module-federation/runtime": "npm:0.9.1"
"@module-federation/sdk": "npm:0.9.1"
checksum: 10/430cac0a770b3c46bc195088eb4c1892e1e29a69238dbe72423d64b2b67050afeca2b5026b1a30659b4fe8d9faa038ff97cceba7e2ddf6193b93763f270d9df6
languageName: node
linkType: hard
@@ -33521,13 +33485,6 @@ __metadata:
languageName: node
linkType: hard
"isomorphic-rslog@npm:0.0.7":
version: 0.0.7
resolution: "isomorphic-rslog@npm:0.0.7"
checksum: 10/cb6f03a64bdbb3972c22429a4fcdff25505ceca2bf09ca2cebc1c8086b2580f67d4dd04daba79d7dd642af099deea1eb884667ddf183bd3192b67faaf86438cc
languageName: node
linkType: hard
"isomorphic-textencoder@npm:^1.0.1":
version: 1.0.1
resolution: "isomorphic-textencoder@npm:1.0.1"