packages/core: separate list of sign-in provider IDs to avoid exporting internal types

2020-06-16 17:18:40 +02:00
parent 506f209742
commit 730b73aff1
1 changed files with 5 additions and 3 deletions
@@ -23,15 +23,17 @@ import {
  useApiHolder,
  errorApiRef,
 } from '@backstage/core-api';
+import { SignInProvider } from './types';

 const PROVIDER_STORAGE_KEY = '@backstage/core:SignInPage:provider';

-const signInProviders = {
+// Separate list here to avoid exporting internal types
+export type SignInProviderId = 'guest';
+
+const signInProviders: { [id in SignInProviderId]: SignInProvider } = {
  guest: guestProvider,
 };

-export type SignInProviderId = keyof typeof signInProviders;
-
 export const useSignInProviders = (
  providers: SignInProviderId[],
  onResult: SignInPageProps['onResult'],