paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 31 Packages Projects Releases Wiki Activity

moved 'undefined' handling to the RelatedEntitiesCard where it belongs

Browse Source 
Signed-off-by: Jonah Grimes <jgrimes@appriss.com>
This commit is contained in:
Jonah Grimes
2021-05-13 09:18:51 -04:00
parent 39a4ba1cf7
commit 70057c1ae0
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog/src/components/RelatedEntitiesCard/RelatedEntitiesCard.tsx
+2 -2
View File
@@ -38,7 +38,7 @@ type Props<T extends Entity> = {
relationType: string;
emptyMessage: string;
emptyHelpLink: string;
asRenderableEntities: (entities?: Entity[]) => T[];
asRenderableEntities: (entities: Entity[]) => T[];
};
export function RelatedEntitiesCard<T extends Entity>({
@@ -86,7 +86,7 @@ export function RelatedEntitiesCard<T extends Entity>({
</div>
}
columns={columns}
entities={asRenderableEntities(entities)}
entities={asRenderableEntities(entities || [])}
/>
);
}
plugins/catalog/src/components/RelatedEntitiesCard/presets.ts
+6 -6
View File
@@ -31,8 +31,8 @@ export const componentEntityColumns: TableColumn<ComponentEntity>[] = [
];
export const componentEntityHelpLink: string =
'https://backstage.io/docs/features/software-catalog/descriptor-format#kind-component';
export const asComponentEntities = (entities?: Entity[]): ComponentEntity[] =>
(entities as ComponentEntity[]) || [];
export const asComponentEntities = (entities: Entity[]): ComponentEntity[] =>
entities as ComponentEntity[];
export const resourceEntityColumns: TableColumn<ResourceEntity>[] = [
EntityTable.columns.createEntityRefColumn({ defaultKind: 'resource' }),
@@ -43,8 +43,8 @@ export const resourceEntityColumns: TableColumn<ResourceEntity>[] = [
];
export const resourceEntityHelpLink: string =
'https://backstage.io/docs/features/software-catalog/descriptor-format#kind-resource';
export const asResourceEntities = (entities?: Entity[]): ResourceEntity[] =>
(entities as ResourceEntity[]) || [];
export const asResourceEntities = (entities: Entity[]): ResourceEntity[] =>
entities as ResourceEntity[];
export const systemEntityColumns: TableColumn<SystemEntity>[] = [
EntityTable.columns.createEntityRefColumn({ defaultKind: 'system' }),
@@ -53,5 +53,5 @@ export const systemEntityColumns: TableColumn<SystemEntity>[] = [
];
export const systemEntityHelpLink: string =
'https://backstage.io/docs/features/software-catalog/descriptor-format#kind-system';
export const asSystemEntities = (entities?: Entity[]): SystemEntity[] =>
(entities as SystemEntity[]) || [];
export const asSystemEntities = (entities: Entity[]): SystemEntity[] =>
entities as SystemEntity[];