resolved @benjdlambert comments

Signed-off-by: Luka Siric <siric.luka@gmail.com>
This commit is contained in:
Luka Siric
2022-08-31 12:27:18 +02:00
parent eef0522644
commit 6ec5064c94
3 changed files with 23 additions and 41 deletions
-1
View File
@@ -1,6 +1,5 @@
---
'@backstage/cli': patch
'@backstage/core-app-api': minor
---
Added support for custom certificate for webpack dev server.
-40
View File
@@ -1,40 +0,0 @@
/*
* Copyright 2022 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export interface Config {
app: {
/**
* Running the frontend app with https
*/
https?: {
/**
* Parent object containing certificate and the private key
*/
certificate?: {
/**
* Https Certificate private key. Use $file to load in a file
* @visibility secret
*/
key: string;
/**
* Https Certificate. Use $file to load in a file
* @visibility secret
*/
cert: string;
};
};
};
}
+23
View File
@@ -248,6 +248,29 @@
"description": "The port that the frontend should be bound to. Only used for local development."
}
}
},
"https": {
"type": "object",
"description": "Running the frontend app with https",
"properties": {
"certificate": {
"type": "object",
"description": "Parent object containing certificate and the private key",
"required": ["key", "cert"],
"properties" : {
"key": {
"type" : "string",
"visibility": "secret",
"description": "Https Certificate private key. Use $file to load in a file"
},
"cert": {
"type" : "string",
"visibility": "secret",
"description": "Https Certificate. Use $file to load in a file"
}
}
}
}
}
}
}