Merge pull request #344 from mateusmarquezini/feature/312-plugin-test-and-list

plugin test and lint should be part of cli e2e test

.github/workflows/frontend.yml

@@ -40,3 +40,10 @@ jobs:
         run: |
           sudo sysctl fs.inotify.max_user_watches=524288
           node scripts/cli-e2e-test.js
+      - name: yarn lint, test after plugin creation
+        working-directory: plugins/test-plugin
+        run: |
+          yarn lint
+          yarn test
+        env:
+          CI: true

packages/cli/src/commands/plugin/assets.d.ts

@@ -1,3 +1,19 @@
+/*
+ * Copyright 2020 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 /// <reference types="node" />
 /// <reference types="react" />
 /// <reference types="react-dom" />

packages/cli/src/commands/plugin/build.ts

@@ -16,10 +16,27 @@
 
 import { Command } from 'commander';
 import fs from 'fs-extra';
-import recursive from 'recursive-readdir';
 import path from 'path';
+import recursive from 'recursive-readdir';
 import { run } from '../../helpers/run';
 
+const copyStaticAssets = async () => {
+  const pluginRoot = fs.realpathSync(process.cwd());
+  const source = path.resolve(pluginRoot, 'src');
+  const destination = path.resolve(pluginRoot, 'dist', 'cjs');
+  const assetFiles = await recursive(source, [
+    '**/*.tsx',
+    '**/*.ts',
+    '**/*.js',
+  ]);
+  assetFiles.forEach(file => {
+    const fileToBeCopied = file.replace(source, destination);
+    const dirForFileToBeCopied = path.dirname(fileToBeCopied);
+    fs.ensureDirSync(dirForFileToBeCopied);
+    fs.copyFileSync(file, file.replace(source, destination).toString());
+  });
+};
+
 export default async (cmd: Command) => {
   const args = [
     '--outDir',
@@ -37,20 +54,3 @@ export default async (cmd: Command) => {
   await copyStaticAssets();
   await run('tsc', args);
 };
-
-const copyStaticAssets = async () => {
-  const pluginRoot = fs.realpathSync(process.cwd());
-  const source = path.resolve(pluginRoot, 'src');
-  const destination = path.resolve(pluginRoot, 'dist', 'cjs');
-  const assetFiles = await recursive(source, [
-    '**/*.tsx',
-    '**/*.ts',
-    '**/*.js',
-  ]);
-  assetFiles.forEach(file => {
-    const fileToBeCopied = file.replace(source, destination);
-    const dirForFileToBeCopied = path.dirname(fileToBeCopied);
-    fs.ensureDirSync(dirForFileToBeCopied);
-    fs.copyFileSync(file, file.replace(source, destination).toString());
-  });
-};

packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.tsx.hbs

@@ -1,3 +1,4 @@
+/* eslint-disable react/prop-types */
 /*
  * Copyright 2020 Spotify AB
  *

packages/cli/templates/default-plugin/src/plugin.test.ts.hbs

@@ -1,3 +1,19 @@
+/*
+ * Copyright 2020 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import plugin from './plugin';
 
 describe('{{ id }}', () => {

packages/cli/templates/default-plugin/src/plugin.ts.hbs

@@ -1,3 +1,19 @@
+/*
+ * Copyright 2020 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { createPlugin } from '@spotify-backstage/core';
 import ExampleComponent from './components/ExampleComponent';
 

packages/core/src/testUtils/logCollector.js

@@ -15,6 +15,7 @@
  */
 
 /* eslint-disable no-console */
+/* eslint-disable no-param-reassign */
 
 // If the callback function is async this one will be too.
 export function withLogCollector(logsToCollect, callback) {