make baseUrl required in client constructor as it is required in configSchema

Signed-off-by: Colton Padden <colton.padden@fastmail.com>
This commit is contained in:
Colton Padden
2021-12-09 10:12:45 -05:00
parent 01c1e2ed2b
commit 6c376f2958
2 changed files with 2 additions and 3 deletions
@@ -30,13 +30,12 @@ export class ApacheAirflowClient implements ApacheAirflowApi {
discoveryApi: DiscoveryApi;
baseUrl: string;
// TODO - need to better determine how to handle undefined baseUrl
constructor({
discoveryApi,
baseUrl = 'http://localhost:8080',
}: {
discoveryApi: DiscoveryApi;
baseUrl?: string;
baseUrl: string;
}) {
this.discoveryApi = discoveryApi;
this.baseUrl = baseUrl.endsWith('/') ? baseUrl : `${baseUrl}/`;
+1 -1
View File
@@ -36,7 +36,7 @@ export const apacheAirflowPlugin = createPlugin({
factory: ({ configApi, discoveryApi }) =>
new ApacheAirflowClient({
discoveryApi,
baseUrl: configApi.getOptionalString('apacheAirflow.baseUrl'),
baseUrl: configApi.getString('apacheAirflow.baseUrl'),
}),
}),
],