Updates changeset design and core change to minor

This commit is contained in:
Juan Lulkin
2021-03-02 17:57:52 +01:00
parent bf169d0320
commit 6b0c3eb8be
+24 -20
View File
@@ -1,27 +1,31 @@
---
'@backstage/core': patch
'@backstage/core': minor
'@backstage/plugin-pagerduty': patch
---
Adds onClick and other props to IconLinkVertical
Allows TriggerButton component to render when pager duty key is missing
Refactors TriggerButton and PagerDutyCard not to have shared state
Removes the `action` prop of the IconLinkVertical component while adding `onClick`. So instead of having an action including a button with onClick, now the whole component can be clickable making it easier to implement and having a better UX. Before:
- Adds onClick and other props to IconLinkVertical;
- Allows TriggerButton component to render when pager duty key is missing;
- Refactors TriggerButton and PagerDutyCard not to have shared state;
- Removes the `action` prop of the IconLinkVertical component while adding `onClick`.
```ts
const myLink : IconLinkVerticalProps = {
label: 'Click me',
action: <Button onClick={myAction} />,
icon: <MyIcon onClick={myAction} />,
}
```
Instead of having an action including a button with onClick, now the whole component can be clickable making it easier to implement and having a better UX.
Before:
After:
```ts
const myLink : IconLinkVerticalProps = {
label: 'Click me',
action: <Button onClick={myAction} />,
icon: <MyIcon onClick={myAction} />,
}
```
```ts
const myLink : IconLinkVerticalProps = {
label: 'Click me',
onClick: myAction,
icon: <MyIcon />,
}
```
After:
```ts
const myLink : IconLinkVerticalProps = {
label: 'Click me',
onClick: myAction,
icon: <MyIcon />,
}
```