Fix some comments
Signed-off-by: Martina Iglesias Fernandez <martina@roadie.io>
This commit is contained in:
+4
-6
@@ -122,12 +122,6 @@ kafka:
|
||||
- localhost:9092
|
||||
|
||||
integrations:
|
||||
googleGcs:
|
||||
clientEmail:
|
||||
$env: GCS_CLIENT_EMAIL
|
||||
privateKey:
|
||||
$env: GCS_PRIVATE_KEY
|
||||
|
||||
github:
|
||||
- host: github.com
|
||||
token:
|
||||
@@ -156,6 +150,10 @@ integrations:
|
||||
- host: dev.azure.com
|
||||
token:
|
||||
$env: AZURE_TOKEN
|
||||
# googleGcs:
|
||||
# clientEmail:
|
||||
# $env: GCS_CLIENT_EMAIL
|
||||
# privateKey: 'example@example.com'
|
||||
|
||||
catalog:
|
||||
rules:
|
||||
|
||||
@@ -22,10 +22,9 @@ import {
|
||||
UrlReader,
|
||||
} from './types';
|
||||
import getRawBody from 'raw-body';
|
||||
import {
|
||||
GOOGLE_GCS_HOST,
|
||||
readGoogleGcsIntegrationConfig,
|
||||
} from '@backstage/integration';
|
||||
import { readGoogleGcsIntegrationConfig } from '@backstage/integration';
|
||||
|
||||
const GOOGLE_GCS_HOST = 'storage.cloud.google.com';
|
||||
|
||||
const parseURL = (
|
||||
url: string,
|
||||
@@ -81,7 +80,7 @@ export class GoogleGcsUrlReader implements UrlReader {
|
||||
this.storage.bucket(bucket).file(key).createReadStream(),
|
||||
);
|
||||
} catch (error) {
|
||||
throw new Error(`unable to read gcs file from ${url}`);
|
||||
throw new Error(`unable to read gcs file from ${url}, ${error}`);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Vendored
+1
-1
@@ -154,7 +154,7 @@ export interface Config {
|
||||
googleGcs?: {
|
||||
/**
|
||||
* Service account email used to authenticate requests.
|
||||
* @visibility secret
|
||||
* @visibility backend
|
||||
*/
|
||||
clientEmail?: string;
|
||||
/**
|
||||
|
||||
@@ -16,4 +16,3 @@
|
||||
|
||||
export { readGoogleGcsIntegrationConfig } from './config';
|
||||
export type { GoogleGcsIntegrationConfig } from './config';
|
||||
export const GOOGLE_GCS_HOST = 'storage.cloud.google.com';
|
||||
|
||||
Reference in New Issue
Block a user