backend-common: added toString methods for all readers + log in backend instead of at creation

packages/backend-common/src/reading/AzureUrlReader.ts

@@ -162,4 +162,9 @@ export class AzureUrlReader implements UrlReader {
       throw new Error(`Incorrect url: ${target}, ${e}`);
     }
   }
+
+  toString() {
+    const { host, token } = this.options;
+    return `azure{host=${host},authed=${Boolean(token)}}`;
+  }
 }

packages/backend-common/src/reading/BitbucketUrlReader.ts

@@ -158,4 +158,9 @@ export class BitbucketUrlReader implements UrlReader {
       throw new Error(`Incorrect url: ${target}, ${e}`);
     }
   }
+
+  toString() {
+    const { host, auth } = this.options;
+    return `bitbucket{host=${host},authed=${Boolean(auth)}}`;
+  }
 }

packages/backend-common/src/reading/FetchUrlReader.ts

@@ -40,4 +40,8 @@ export class FetchUrlReader implements UrlReader {
     }
     throw new Error(message);
   }
+
+  toString() {
+    return 'fetch{}';
+  }
 }

packages/backend-common/src/reading/GithubUrlReader.ts

@@ -229,4 +229,9 @@ export class GithubUrlReader implements UrlReader {
     }
     throw new Error(message);
   }
+
+  toString() {
+    const { host, token } = this.config;
+    return `github{host=${host},authed=${Boolean(token)}}`;
+  }
 }

packages/backend-common/src/reading/GitlabUrlReader.ts

@@ -187,4 +187,9 @@ export class GitlabUrlReader implements UrlReader {
       throw new Error(`Could not get GitLab ProjectID for: ${target}, ${e}`);
     }
   }
+
+  toString() {
+    const { host, token } = this.options;
+    return `gitlab{host=${host},authed=${Boolean(token)}}`;
+  }
 }

packages/backend-common/src/reading/UrlReaderPredicateMux.ts

@@ -59,4 +59,10 @@ export class UrlReaderPredicateMux implements UrlReader {
 
     throw new Error(`No reader found that could handle '${url}'`);
   }
+
+  toString() {
+    return `predicateMux{readers=${this.readers
+      .map(t => t.reader)
+      .join(',')},fallback=${this.fallback}}`;
+  }
 }

packages/backend-common/src/reading/UrlReaders.ts

@@ -79,21 +79,15 @@ export class UrlReaders {
    */
   createWithConfig(config: Config): UrlReader {
     const mux = new UrlReaderPredicateMux({ fallback: this.fallback });
-    const readers = [];
 
     for (const factory of this.factories) {
       const tuples = factory({ config, logger: this.logger });
 
       for (const tuple of tuples) {
         mux.register(tuple);
-        readers.push(tuple.reader);
       }
     }
 
-    this.logger.info(
-      `Registered the following UrlReaders: ${readers.join(', ')}`,
-    );
-
     return mux;
   }
 

packages/backend/src/index.ts

@@ -50,9 +50,14 @@ import { PluginEnvironment } from './types';
 
 function makeCreateEnv(loadedConfigs: AppConfig[]) {
   const config = ConfigReader.fromConfigs(loadedConfigs);
+  const root = getRootLogger();
+  const reader = UrlReaders.default({ logger: root }).createWithConfig(config);
+  const discovery = SingleHostDiscovery.fromConfig(config);
+
+  root.info(`Created UrlReader ${reader}`);
 
   return (plugin: string): PluginEnvironment => {
-    const logger = getRootLogger().child({ type: 'plugin', plugin });
+    const logger = root.child({ type: 'plugin', plugin });
     const database = createDatabaseClient(
       config.getConfig('backend.database'),
       {
@@ -61,8 +66,6 @@ function makeCreateEnv(loadedConfigs: AppConfig[]) {
         },
       },
     );
-    const reader = UrlReaders.default({ logger }).createWithConfig(config);
-    const discovery = SingleHostDiscovery.fromConfig(config);
     return { logger, database, config, reader, discovery };
   };
 }

packages/create-app/templates/default-app/packages/backend/src/index.ts

@@ -28,9 +28,14 @@ import { PluginEnvironment } from './types';
 
 function makeCreateEnv(loadedConfigs: AppConfig[]) {
   const config = ConfigReader.fromConfigs(loadedConfigs);
+  const root = getRootLogger();
+  const reader = UrlReaders.default({ logger: root }).createWithConfig(config);
+  const discovery = SingleHostDiscovery.fromConfig(config);
+
+  root.info(`Created UrlReader ${reader}`);
 
   return (plugin: string): PluginEnvironment => {
-    const logger = getRootLogger().child({ type: 'plugin', plugin });
+    const logger = root.child({ type: 'plugin', plugin });
     const database = createDatabaseClient(
       config.getConfig('backend.database'),
       {
@@ -39,8 +44,6 @@ function makeCreateEnv(loadedConfigs: AppConfig[]) {
         },
       },
     );
-    const reader = UrlReaders.default({ logger }).createWithConfig(config);
-    const discovery = SingleHostDiscovery.fromConfig(config);
     return { logger, database, config, reader, discovery };
   };
 }