Move backend lint config to cli config

.eslintrc.js

@@ -1,6 +1,4 @@
 module.exports = {
-  extends: [
-    require.resolve('@backstage/cli/config/eslint'),
-    '@spotify/eslint-config-oss',
-  ],
+  root: true,
+  extends: ['@spotify/eslint-config-oss'],
 };

packages/backend/.eslintrc.js

@@ -1,6 +1,3 @@
 module.exports = {
-  rules: {
-    'no-console': 0, // Permitted in console programs
-    'new-cap': ['error', { capIsNew: false }], // Because Express constructs things e.g. like 'const r = express.Router()'
-  },
+  extends: [require.resolve('@backstage/cli/config/eslint.backend')],
 };

packages/cli/config/eslint.backend.js

@@ -0,0 +1,71 @@
+/*
+ * Copyright 2020 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+module.exports = {
+  extends: [
+    '@spotify/eslint-config-base',
+    '@spotify/eslint-config-typescript',
+    'prettier',
+    'prettier/@typescript-eslint',
+    'plugin:jest/recommended',
+    'plugin:monorepo/recommended',
+  ],
+  parser: '@typescript-eslint/parser',
+  plugins: ['import'],
+  env: {
+    jest: true,
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: 'module',
+  },
+  ignorePatterns: ['**/dist/**', '**/build/**'],
+  rules: {
+    'no-console': 0, // Permitted in console programs
+    'new-cap': ['error', { capIsNew: false }], // Because Express constructs things e.g. like 'const r = express.Router()'
+    'import/no-duplicates': 'warn',
+    'import/no-extraneous-dependencies': [
+      'error',
+      {
+        devDependencies: false,
+        optionalDependencies: true,
+        peerDependencies: true,
+        bundledDependencies: true,
+      },
+    ],
+    '@typescript-eslint/no-unused-vars': [
+      'warn',
+      { vars: 'all', args: 'after-used', ignoreRestSiblings: true },
+    ],
+  },
+  overrides: [
+    {
+      files: ['*.test.*', 'src/setupTests.*', 'dev/**'],
+      rules: {
+        // Tests are allowed to import dev dependencies
+        'import/no-extraneous-dependencies': [
+          'error',
+          {
+            devDependencies: true,
+            optionalDependencies: true,
+            peerDependencies: true,
+            bundledDependencies: true,
+          },
+        ],
+      },
+    },
+  ],
+};

packages/test-utils-core/package.json

@@ -21,7 +21,8 @@
   "scripts": {
     "build": "backstage-cli plugin:build",
     "lint": "backstage-cli lint",
-    "test": "backstage-cli test"
+    "test": "backstage-cli test",
+    "clean": "backstage-cli clean"
   },
   "dependencies": {
     "@testing-library/jest-dom": "^4.2.4",

packages/theme/.eslintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  extends: [require.resolve('@backstage/cli/config/eslint')],
+};

plugins/inventory-backend/.eslintrc.js

@@ -1,6 +1,3 @@
 module.exports = {
-  rules: {
-    'no-console': 0, // Permitted in console programs
-    'new-cap': ['error', { capIsNew: false }], // Because Express constructs things e.g. like 'const r = express.Router()'
-  },
+  extends: [require.resolve('@backstage/cli/config/eslint.backend')],
 };

plugins/tech-radar/.eslintrc.js

@@ -1,3 +1,3 @@
 module.exports = {
-  extends: [require.resolve('@backstage/cli/config/eslint.js')],
+  extends: [require.resolve('@backstage/cli/config/eslint')],
 };