Apply suggestions from code review

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2021-10-04 17:18:40 +02:00
parent fddfb5e10f
commit 670f79ded3
+3 -4
View File
@@ -99,9 +99,8 @@ component for the outside world, and is used by other components and plugins
that wish to link to the routable component.
As of now there are only two extension creation functions in the core library,
but it is possible to add more of them in the future, but more may be added in
the future. There are also some plugins that provide ways to extend
functionality through their own extensions, like
but more may be added in the future. There are also some plugins that provide
ways to extend functionality through their own extensions, like
`createScaffolderFieldExtension` from `@backstage/plugin-scaffolder`. Extensions
are also not tied to React, and can both be used to model generic JavaScript
concepts, as well as potentially bridge to rendering libraries and web
@@ -318,7 +317,7 @@ top-level `routes.ts`. This is to avoid circular imports when you use the route
references from other parts of the same plugin.
Another thing to note is that this indirection in the routing is particularly
useful for open source plugins than need to leave flexibility in how they are
useful for open source plugins that need to leave flexibility in how they are
integrated. For plugins that you build internally for your own Backstage
application, you can choose to go the route of direct imports or even use
concrete routes directly. Although there can be some benefits to using the full