Merge pull request #25577 from skyem/master

fix: Added owner and repo args to getEnvironmentPublicKey

.changeset/early-deers-beg.md

@@ -0,0 +1,7 @@
+---
+'@backstage/plugin-scaffolder-backend-module-github': patch
+---
+
+Fixed bug resulting from missing required owner and repo arguments in `getEnvironmentPublicKey` in action `github:environment:create`.
+
+Adding environment secrets now works as expected.

plugins/scaffolder-backend-module-github/src/actions/githubEnvironment.test.ts

@@ -304,5 +304,16 @@ describe('github:environment:create', () => {
       key_id: 'keyid',
       encrypted_value: expect.any(String),
     });
+    expect(
+      mockOctokit.rest.actions.getEnvironmentPublicKey,
+    ).toHaveBeenCalledTimes(1);
+    expect(
+      mockOctokit.rest.actions.getEnvironmentPublicKey,
+    ).toHaveBeenCalledWith({
+      repository_id: 'repoid',
+      owner: 'owner',
+      repo: 'repository',
+      environment_name: 'envname',
+    });
   });
 });

plugins/scaffolder-backend-module-github/src/actions/githubEnvironment.ts

@@ -199,6 +199,8 @@ export function createGithubEnvironmentAction(options: {
         const publicKeyResponse =
           await client.rest.actions.getEnvironmentPublicKey({
             repository_id: repository.data.id,
+            owner: owner,
+            repo: repo,
             environment_name: name,
           });