Add tests for google auth provider
This commit is contained in:
Raghunandan
@@ -16,17 +16,46 @@
|
||||
|
||||
import { GoogleAuthProvider } from './provider';
|
||||
import passport from 'passport';
|
||||
import express from 'express';
|
||||
import * as passportGoogleAuth20 from 'passport-google-oauth20';
|
||||
// import * as utils from './../utils';
|
||||
|
||||
const googleAuthProviderConfig = {
|
||||
provider: 'google',
|
||||
options: {
|
||||
clientID: 'a',
|
||||
clientSecret: 'b',
|
||||
callbackURL: 'c',
|
||||
},
|
||||
};
|
||||
|
||||
const googleAuthProviderConfigFromEnv = {
|
||||
provider: 'google',
|
||||
options: {
|
||||
clientID: process.env.AUTH_GOOGLE_CLIENT_ID,
|
||||
clientSecret: process.env.AUTH_GOOGLE_CLIENT_SECRET,
|
||||
callbackURL: 'c',
|
||||
},
|
||||
};
|
||||
|
||||
const googleAuthProviderConfigMissingInEnv = {
|
||||
provider: 'google',
|
||||
options: {
|
||||
clientID: process.env.MISSING_CLIENT_ID,
|
||||
clientSecret: process.env.MISSING_CLIENT_SECRET,
|
||||
callbackURL: 'c',
|
||||
},
|
||||
};
|
||||
|
||||
const googleAuthProviderConfigInvalidOptions = {
|
||||
provider: 'google',
|
||||
options: {},
|
||||
};
|
||||
|
||||
const googleAuthProviderConfigInvalid = {
|
||||
provider: 'google',
|
||||
};
|
||||
|
||||
describe('GoogleAuthProvider', () => {
|
||||
afterEach(() => {
|
||||
jest.clearAllMocks();
|
||||
});
|
||||
describe('create a new provider', () => {
|
||||
it('should succeed with valid config', () => {
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
@@ -39,4 +68,132 @@ describe('GoogleAuthProvider', () => {
|
||||
expect(googleAuthProvider.strategy).toBeDefined();
|
||||
});
|
||||
});
|
||||
|
||||
describe('start authentication handler', () => {
|
||||
const mockResponse: any = ({} as unknown) as express.Response;
|
||||
const mockNext: express.NextFunction = jest.fn();
|
||||
|
||||
it('should initiate authenticate request with provided scopes', () => {
|
||||
const mockRequest = ({
|
||||
query: {
|
||||
scopes: 'a,b',
|
||||
},
|
||||
} as unknown) as express.Request;
|
||||
|
||||
const spyPassport = jest
|
||||
.spyOn(passport, 'authenticate')
|
||||
.mockImplementation(() => jest.fn());
|
||||
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfig,
|
||||
);
|
||||
googleAuthProvider.start(mockRequest, mockResponse, mockNext);
|
||||
expect(spyPassport).toBeCalledTimes(1);
|
||||
expect(spyPassport).toBeCalledWith('google', {
|
||||
scope: ['a', 'b'],
|
||||
accessType: 'offline',
|
||||
prompt: 'consent',
|
||||
});
|
||||
});
|
||||
|
||||
it('should throw error if no scopes provided', () => {
|
||||
const mockRequest = ({
|
||||
query: {},
|
||||
} as unknown) as express.Request;
|
||||
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfig,
|
||||
);
|
||||
expect(() => {
|
||||
googleAuthProvider.start(mockRequest, mockResponse, mockNext);
|
||||
}).toThrowError('Scopes should be specified');
|
||||
});
|
||||
});
|
||||
|
||||
describe('logout handler', () => {
|
||||
const mockRequest = ({} as unknown) as express.Request;
|
||||
|
||||
it('should perform logout and respond with 200', () => {
|
||||
const mockResponse: any = ({
|
||||
send: jest.fn(),
|
||||
} as unknown) as express.Response;
|
||||
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfig,
|
||||
);
|
||||
|
||||
const spyResponse = jest
|
||||
.spyOn(mockResponse, 'send')
|
||||
.mockImplementation(() => jest.fn());
|
||||
|
||||
googleAuthProvider.logout(mockRequest, mockResponse);
|
||||
expect(spyResponse).toBeCalledTimes(1);
|
||||
expect(spyResponse).toBeCalledWith('logout!');
|
||||
});
|
||||
});
|
||||
|
||||
describe('redirect frame handler', () => {
|
||||
const mockRequest = ({} as unknown) as express.Request;
|
||||
const mockResponse: any = ({
|
||||
send: jest.fn(),
|
||||
} as unknown) as express.Response;
|
||||
const mockNext: express.NextFunction = jest.fn();
|
||||
|
||||
it('should call authenticate and post a response ', () => {
|
||||
// TODO: Unable to verify if post message is being called
|
||||
// const spyPostMessage = jest
|
||||
// .spyOn(utils, 'postMessageResponse')
|
||||
// .mockImplementation(() => jest.fn());
|
||||
|
||||
const spyPassport = jest
|
||||
.spyOn(passport, 'authenticate')
|
||||
.mockImplementation(() => jest.fn());
|
||||
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfig,
|
||||
);
|
||||
|
||||
googleAuthProvider.frameHandler(mockRequest, mockResponse, mockNext);
|
||||
expect(spyPassport).toBeCalledTimes(1);
|
||||
// expect(spyPostMessage).toBeCalledTimes(1);
|
||||
});
|
||||
});
|
||||
|
||||
describe('strategy handler', () => {
|
||||
it('should return a valid passport strategy', () => {
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfig,
|
||||
);
|
||||
|
||||
// TODO: how to test the callback function?
|
||||
expect(googleAuthProvider.strategy()).toBeInstanceOf(passport.Strategy);
|
||||
});
|
||||
|
||||
it('should return a valid passport strategy if secrets in env', () => {
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfigFromEnv,
|
||||
);
|
||||
|
||||
expect(googleAuthProvider.strategy()).toBeInstanceOf(passport.Strategy);
|
||||
});
|
||||
|
||||
// TODO: The two tests below should throw errors because either
|
||||
// the options are missing in env or not present at all
|
||||
// but they aren't throwing errors
|
||||
it('should throw an error if secrets missing in env', () => {
|
||||
expect(() => {
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfigMissingInEnv,
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
it('should throw an error for invalid options', () => {
|
||||
expect(() => {
|
||||
const googleAuthProvider = new GoogleAuthProvider(
|
||||
googleAuthProviderConfigInvalidOptions,
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
@@ -69,6 +69,7 @@ export class GoogleAuthProvider
|
||||
}
|
||||
|
||||
strategy(): passport.Strategy {
|
||||
// TODO: throw error if env variables not set?
|
||||
return new GoogleStrategy(
|
||||
{ ...this.providerConfig.options },
|
||||
(
|
||||
|
||||
@@ -15,3 +15,5 @@
|
||||
*/
|
||||
|
||||
require('jest-fetch-mock').enableMocks();
|
||||
process.env.AUTH_GOOGLE_CLIENT_ID = 'a';
|
||||
process.env.AUTH_GOOGLE_CLIENT_SECRET = 'b';
|
||||
|
||||
@@ -9,7 +9,7 @@
|
||||
dependencies:
|
||||
"@babel/highlight" "^7.0.0"
|
||||
|
||||
"@babel/code-frame@7.8.3", "@babel/code-frame@^7.0.0", "@babel/code-frame@^7.5.5", "@babel/code-frame@^7.8.3":
|
||||
"@babel/code-frame@7.8.3", "@babel/code-frame@^7.0.0", "@babel/code-frame@^7.8.3":
|
||||
version "7.8.3"
|
||||
resolved "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.8.3.tgz#33e25903d7481181534e12ec0a25f16b6fcf419e"
|
||||
integrity sha512-a9gxpmdXtZEInkCSHUJDLHZVBgb1QS0jhss4cPP93EW7s+uC5bikET2twEF3KV+7rDblJcmNvTR7VJejqd2C2g==
|
||||
@@ -3961,9 +3961,9 @@
|
||||
"@types/uglify-js" "*"
|
||||
|
||||
"@types/html-webpack-plugin@*", "@types/html-webpack-plugin@^3.2.2":
|
||||
version "3.2.3"
|
||||
resolved "https://registry.npmjs.org/@types/html-webpack-plugin/-/html-webpack-plugin-3.2.3.tgz#865323e30e82560c0ca898dbf9f6f9d1c541cd7f"
|
||||
integrity sha512-Y7dsVhTn75IaD4lMIY02UP1L8e0ou8KQu8DKPJAegEFKdJR28/8ejayDG8ykfR0DtYCx3dCEHIkdpN8AOB6txQ==
|
||||
version "3.2.2"
|
||||
resolved "https://registry.npmjs.org/@types/html-webpack-plugin/-/html-webpack-plugin-3.2.2.tgz#f552121f3c0a3972dda9a425de1e0029069b2907"
|
||||
integrity sha512-KsL5cHtNWhOQF9Cu+Dpn7GemzQRxdKhe1/LgZUSku33B5L4Cx2/p3DX6YbeRNOoI552MNbB/VNbCDNEYU//iAw==
|
||||
dependencies:
|
||||
"@types/html-minifier" "*"
|
||||
"@types/tapable" "*"
|
||||
@@ -4069,9 +4069,9 @@
|
||||
integrity sha512-ijGqzZt/b7BfzcK9vTrS6MFljQRPn5BFWOx8oE0GYxribu6uV+aA9zZuXI1zc/etK9E8nrgdoF2+LgUw7+9tJQ==
|
||||
|
||||
"@types/lodash@^4.14.151":
|
||||
version "4.14.152"
|
||||
resolved "https://registry.npmjs.org/@types/lodash/-/lodash-4.14.152.tgz#7e7679250adce14e749304cdb570969f77ec997c"
|
||||
integrity sha512-Vwf9YF2x1GE3WNeUMjT5bTHa2DqgUo87ocdgTScupY2JclZ5Nn7W2RLM/N0+oreexUk8uaVugR81NnTY/jNNXg==
|
||||
version "4.14.151"
|
||||
resolved "https://registry.npmjs.org/@types/lodash/-/lodash-4.14.151.tgz#7d58cac32bedb0ec37cb7f99094a167d6176c9d5"
|
||||
integrity sha512-Zst90IcBX5wnwSu7CAS0vvJkTjTELY4ssKbHiTnGcJgi170uiS8yQDdc3v6S77bRqYQIN1App5a1Pc2lceE5/g==
|
||||
|
||||
"@types/mime@*":
|
||||
version "2.0.1"
|
||||
@@ -5370,7 +5370,7 @@ aws4@^1.8.0:
|
||||
resolved "https://registry.npmjs.org/aws4/-/aws4-1.9.1.tgz#7e33d8f7d449b3f673cd72deb9abdc552dbe528e"
|
||||
integrity sha512-wMHVg2EOHaMRxbzgFJ9gtjOOCrI80OHLG14rxi28XwOW8ux6IiEbRCGGGqCtdAIg4FQCbW20k9RsT4y3gJlFug==
|
||||
|
||||
axios@^0.19.0:
|
||||
axios@^0.19.0, axios@^0.19.2:
|
||||
version "0.19.2"
|
||||
resolved "https://registry.npmjs.org/axios/-/axios-0.19.2.tgz#3ea36c5d8818d0d5f8a8a97a6d36b86cdc00cb27"
|
||||
integrity sha512-fjgm5MvRHLhx+osE2xoekY70AhARk3a6hkN+3Io1jc00jtquGvxYlKlsFUhmUET0V5te6CcZI7lcv2Ym61mjHA==
|
||||
@@ -9749,11 +9749,11 @@ fork-ts-checker-webpack-plugin@3.1.1:
|
||||
worker-rpc "^0.1.0"
|
||||
|
||||
fork-ts-checker-webpack-plugin@^4.0.5:
|
||||
version "4.1.4"
|
||||
resolved "https://registry.npmjs.org/fork-ts-checker-webpack-plugin/-/fork-ts-checker-webpack-plugin-4.1.4.tgz#f0dc3ece19ec5b792d7b8ecd2a7f43509a5285ce"
|
||||
integrity sha512-R0nTlZSyV0uCCzYe1kgR7Ve8mXyDvMm1pJwUFb6zzRVF5rTNb24G6gn2DFQy+W5aJYp2eq8aexpCOO+1SCyCSA==
|
||||
version "4.1.0"
|
||||
resolved "https://registry.npmjs.org/fork-ts-checker-webpack-plugin/-/fork-ts-checker-webpack-plugin-4.1.0.tgz#62bffe704426770fee33f15f0c0d56c86297fefd"
|
||||
integrity sha512-2DLwUVUR/AdNmMD2utfmSR8r4qHRFhnfL6QQDQS5q4g5uBZzXYDgg8MXPIbu0HzyLjyvbogqjBNKILG5fufwzg==
|
||||
dependencies:
|
||||
"@babel/code-frame" "^7.5.5"
|
||||
babel-code-frame "^6.22.0"
|
||||
chalk "^2.4.1"
|
||||
micromatch "^3.1.10"
|
||||
minimatch "^3.0.4"
|
||||
@@ -20444,10 +20444,15 @@ typedarray@^0.0.6:
|
||||
resolved "https://registry.npmjs.org/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
|
||||
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
|
||||
|
||||
typescript@^3.7.4, typescript@^3.9.2:
|
||||
version "3.9.3"
|
||||
resolved "https://registry.npmjs.org/typescript/-/typescript-3.9.3.tgz#d3ac8883a97c26139e42df5e93eeece33d610b8a"
|
||||
integrity sha512-D/wqnB2xzNFIcoBG9FG8cXRDjiqSTbG2wd8DMZeQyJlP1vfTkIxH4GKveWaEBYySKIg+USu+E+EDIR47SqnaMQ==
|
||||
typescript@^3.7.4:
|
||||
version "3.8.3"
|
||||
resolved "https://registry.npmjs.org/typescript/-/typescript-3.8.3.tgz#409eb8544ea0335711205869ec458ab109ee1061"
|
||||
integrity sha512-MYlEfn5VrLNsgudQTVJeNaQFUAI7DkhnOjdpAp4T+ku1TfQClewlbSuTVHiA+8skNBgaf02TL/kLOvig4y3G8w==
|
||||
|
||||
typescript@^3.9.2:
|
||||
version "3.9.2"
|
||||
resolved "https://registry.npmjs.org/typescript/-/typescript-3.9.2.tgz#64e9c8e9be6ea583c54607677dd4680a1cf35db9"
|
||||
integrity sha512-q2ktq4n/uLuNNShyayit+DTobV2ApPEo/6so68JaD5ojvc/6GClBipedB9zNWYxRSAlZXAe405Rlijzl6qDiSw==
|
||||
|
||||
uc.micro@^1.0.1, uc.micro@^1.0.5:
|
||||
version "1.0.6"
|
||||
@@ -20884,9 +20889,9 @@ uuid@^7.0.3:
|
||||
integrity sha512-DPSke0pXhTZgoF/d+WSt2QaKMCFSfx7QegxEWT+JOuHF5aWrKEn0G+ztjuJg/gG8/ItK+rbPCD/yNv8yyih6Cg==
|
||||
|
||||
uuid@^8.0.0:
|
||||
version "8.1.0"
|
||||
resolved "https://registry.npmjs.org/uuid/-/uuid-8.1.0.tgz#6f1536eb43249f473abc6bd58ff983da1ca30d8d"
|
||||
integrity sha512-CI18flHDznR0lq54xBycOVmphdCYnQLKn8abKn7PXUiKUGdEd+/l9LWNJmugXel4hXq7S+RMNl34ecyC9TntWg==
|
||||
version "8.0.0"
|
||||
resolved "https://registry.npmjs.org/uuid/-/uuid-8.0.0.tgz#bc6ccf91b5ff0ac07bbcdbf1c7c4e150db4dbb6c"
|
||||
integrity sha512-jOXGuXZAWdsTH7eZLtyXMqUb9EcWMGZNbL9YcGBJl4MH4nrxHmZJhEHvyLFrkxo+28uLb/NYRcStH48fnD0Vzw==
|
||||
|
||||
v8-compile-cache@^2.0.3:
|
||||
version "2.1.0"
|
||||
|
||||
Reference in New Issue
Block a user