Merge pull request #22239 from lshwayne96/fix/events-aws-sqs

Events backend module AWS SQS - Fix errors when deleting SQS messages

.changeset/shaggy-coins-happen.md

@@ -0,0 +1,8 @@
+---
+'@backstage/plugin-events-backend-module-aws-sqs': patch
+---
+
+Fix errors when deleting SQS messages:
+
+- If zero messages were received, skip deletion to avoid `EmptyBatchRequest` error from the SQS client.
+- If zero failures were returned from the SQS client during deletion, skip error logging.

plugins/events-backend-module-aws-sqs/src/publisher/AwsSqsConsumingEventPublisher.ts

@@ -111,7 +111,7 @@ export class AwsSqsConsumingEventPublisher implements EventPublisher {
   }
 
   private async deleteMessages(messages?: Message[]): Promise<void> {
-    if (!messages) {
+    if (!messages || messages.length === 0) {
       return;
     }
 
@@ -129,7 +129,7 @@ export class AwsSqsConsumingEventPublisher implements EventPublisher {
       const result = await this.sqs.send(
         new DeleteMessageBatchCommand(deleteParams),
       );
-      if (result.Failed) {
+      if (result.Failed && result.Failed.length > 0) {
         this.logger.error(
           `Failed to delete ${result.Failed!.length} of ${
             messages.length