paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 40 Packages Projects Releases Wiki Activity

Pass default columns func on prop

Browse Source 
Signed-off-by: Paul Stoker <pstoker@spotify.com>
This commit is contained in:
Paul Stoker
2023-11-17 09:43:18 +01:00
parent e41cb05b57
commit 61a9d35578
1 changed files with 47 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog/src/components/CatalogTable/CatalogTable.tsx
+47 -45
View File
@@ -86,53 +86,57 @@ const refCompare = (a: Entity, b: Entity) => {
return toRef(a).localeCompare(toRef(b));
};
const defaultColumnsFunc: CatalogTableColumnsFunc = ({ filters, entities }) => {
return [
columnFactories.createTitleColumn({ hidden: true }),
columnFactories.createNameColumn({ defaultKind: filters.kind?.value }),
...createEntitySpecificColumns(),
columnFactories.createMetadataDescriptionColumn(),
columnFactories.createTagsColumn(),
];
function createEntitySpecificColumns(): TableColumn<CatalogTableRow>[] {
const baseColumns = [
columnFactories.createSystemColumn(),
columnFactories.createOwnerColumn(),
columnFactories.createSpecTypeColumn(),
columnFactories.createSpecLifecycleColumn(),
];
switch (filters.kind?.value) {
case 'user':
return [];
case 'domain':
case 'system':
return [columnFactories.createOwnerColumn()];
case 'group':
case 'template':
return [columnFactories.createSpecTypeColumn()];
case 'location':
return [
columnFactories.createSpecTypeColumn(),
columnFactories.createSpecTargetsColumn(),
];
default:
return entities.every(entity => entity.metadata.namespace === 'default')
? baseColumns
: [...baseColumns, columnFactories.createNamespaceColumn()];
}
}
};
/** @public */
export const CatalogTable = (props: CatalogTableProps) => {
const { columns, actions, tableOptions, subtitle, emptyContent } = props;
const {
columns = defaultColumnsFunc,
actions,
tableOptions,
subtitle,
emptyContent,
} = props;
const { isStarredEntity, toggleStarredEntity } = useStarredEntities();
const entityListContext = useEntityList();
const { loading, error, entities, filters } = entityListContext;
const defaultColumns: TableColumn<CatalogTableRow>[] = useMemo(() => {
return [
columnFactories.createTitleColumn({ hidden: true }),
columnFactories.createNameColumn({ defaultKind: filters.kind?.value }),
...createEntitySpecificColumns(),
columnFactories.createMetadataDescriptionColumn(),
columnFactories.createTagsColumn(),
];
function createEntitySpecificColumns(): TableColumn<CatalogTableRow>[] {
const baseColumns = [
columnFactories.createSystemColumn(),
columnFactories.createOwnerColumn(),
columnFactories.createSpecTypeColumn(),
columnFactories.createSpecLifecycleColumn(),
];
switch (filters.kind?.value) {
case 'user':
return [];
case 'domain':
case 'system':
return [columnFactories.createOwnerColumn()];
case 'group':
case 'template':
return [columnFactories.createSpecTypeColumn()];
case 'location':
return [
columnFactories.createSpecTypeColumn(),
columnFactories.createSpecTargetsColumn(),
];
default:
return entities.every(
entity => entity.metadata.namespace === 'default',
)
? baseColumns
: [...baseColumns, columnFactories.createNamespaceColumn()];
}
}
}, [filters.kind?.value, entities]);
const overrideColumns = useMemo(() => {
return typeof columns === 'function' ? columns(entityListContext) : columns;
}, [columns, entityListContext]);
@@ -243,9 +247,7 @@ export const CatalogTable = (props: CatalogTableProps) => {
};
});
const typeColumn = (overrideColumns || defaultColumns).find(
c => c.title === 'Type',
);
const typeColumn = overrideColumns.find(c => c.title === 'Type');
if (typeColumn) {
typeColumn.hidden = !showTypeColumn;
}
@@ -259,7 +261,7 @@ export const CatalogTable = (props: CatalogTableProps) => {
return (
<Table<CatalogTableRow>
isLoading={loading}
columns={overrideColumns || defaultColumns}
columns={overrideColumns}
options={{
paging: showPagination,
pageSize: 20,