Merge pull request #27255 from RedlineTriad/event-bus-config-propagation

fix: `useEventBus` by propagating config to `DefaultEventsService`
This commit is contained in:
Patrik Oldsberg
2024-10-21 17:59:48 +02:00
committed by GitHub
5 changed files with 13 additions and 5 deletions
+6
View File
@@ -0,0 +1,6 @@
---
'@backstage/plugin-events-backend': patch
'@backstage/plugin-events-node': patch
---
Fix `events.useEventBus` by propagating config to `DefaultEventsService`
+1 -1
View File
@@ -73,7 +73,7 @@ function makeCreateEnv(config: Config) {
discovery,
});
const eventsService = DefaultEventsService.create({ logger: root });
const eventsService = DefaultEventsService.create({ logger: root, config });
const eventBroker = new DefaultEventBroker(
root.child({ type: 'plugin' }),
eventsService,
@@ -42,7 +42,8 @@ export class DefaultEventBroker implements EventBroker {
* @deprecated use `DefaultEventsService` directly instead
*/
constructor(logger: LoggerService, events?: EventsService) {
this.events = events ?? DefaultEventsService.create({ logger });
this.events =
events ?? DefaultEventsService.create({ logger, useEventBus: 'never' });
}
async publish(params: EventParams): Promise<void> {
+1 -1
View File
@@ -27,7 +27,7 @@ import { DefaultEventsService } from '@backstage/plugin-events-node';
function makeCreateEnv(config: Config) {
// ...
const eventsService = DefaultEventsService.create({ logger: root });
const eventsService = DefaultEventsService.create({ logger: root, config });
// ...
return (plugin: string): PluginEnvironment => {
// ...
+3 -2
View File
@@ -42,9 +42,10 @@ export const eventsServiceFactory = createServiceFactory({
logger: coreServices.logger,
lifecycle: coreServices.lifecycle,
auth: coreServices.auth,
config: coreServices.rootConfig,
},
async createRootContext({ rootLogger }) {
return DefaultEventsService.create({ logger: rootLogger });
async createRootContext({ rootLogger, config }) {
return DefaultEventsService.create({ logger: rootLogger, config });
},
async factory(
{ pluginMetadata, discovery, logger, lifecycle, auth },