backend-common: review fixes for service shims

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

.changeset/lucky-sheep-cover.md

@@ -2,4 +2,4 @@
 '@backstage/backend-common': patch
 ---
 
-The `legacyPlugin` and `makeLeagcyPlugin` helpers now provide their own shim implementation of the identity and token manager services, as these services are being removed from the new backend system.
+The `legacyPlugin` and `makeLegacyPlugin` helpers now provide their own shim implementation of the identity and token manager services, as these services are being removed from the new backend system.

packages/backend-common/api-report.md

@@ -362,7 +362,7 @@ export const legacyPlugin: (
           };
         }
       > & {
-        tokenManager: ServerTokenManager;
+        tokenManager: TokenManager;
         identity: LegacyIdentityService;
       }
     >;
@@ -405,7 +405,7 @@ export function makeLegacyPlugin<
   createRouterImport: Promise<{
     default: LegacyCreateRouter<
       TransformedEnv<TEnv, TEnvTransforms> & {
-        tokenManager: ServerTokenManager;
+        tokenManager: TokenManager;
         identity: LegacyIdentityService;
       }
     >;

packages/backend-common/src/compat/legacy/legacy.ts

@@ -76,7 +76,7 @@ function createTokenManagerShim(
 }
 
 /**
- * Originally IdentityApi from `@backstage/plugin-auth-node`, not re-declared here for backwards compatibility
+ * Originally IdentityApi from `@backstage/plugin-auth-node`, re-declared here for backwards compatibility
  * @public
  * @deprecated Only relevant for legacy plugins, which are deprecated.
  */
@@ -154,7 +154,7 @@ export function makeLegacyPlugin<
     createRouterImport: Promise<{
       default: LegacyCreateRouter<
         TransformedEnv<TEnv, TEnvTransforms> & {
-          tokenManager: ServerTokenManager;
+          tokenManager: TokenManager;
           identity: LegacyIdentityService;
         }
       >;
@@ -207,7 +207,7 @@ export function makeLegacyPlugin<
 
             const pluginRouter = await createRouter(
               pluginEnv as TransformedEnv<TEnv, TEnvTransforms> & {
-                tokenManager: ServerTokenManager;
+                tokenManager: TokenManager;
                 identity: LegacyIdentityService;
               },
             );