remove batchAddOrUpdateEntities too

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

.changeset/khaki-adults-own.md

@@ -36,6 +36,10 @@ The following classes and interfaces have been removed:
 - `DbLocationsRow`
 - `DbLocationsRowWithStatus`
 - `DbPageInfo`
+- `EntitiesCatalog.batchAddOrUpdateEntities` (was only used by the legacy
+  engine)
+- `EntityUpsertRequest`
+- `EntityUpsertResponse`
 - `HigherOrderOperation`
 - `HigherOrderOperations`
 - `LocationReader`

plugins/catalog-backend/api-report.md

@@ -554,14 +554,6 @@ export type EntitiesCatalog = {
       authorizationToken?: string;
     },
   ): Promise<void>;
-  batchAddOrUpdateEntities?(
-    requests: EntityUpsertRequest[],
-    options?: {
-      locationId?: string;
-      dryRun?: boolean;
-      outputEntities?: boolean;
-    },
-  ): Promise<EntityUpsertResponse[]>;
   entityAncestry(entityRef: string): Promise<EntityAncestryResponse>;
 };
 
@@ -689,22 +681,6 @@ export type EntityProviderMutation =
       removed: DeferredEntity[];
     };
 
-// Warning: (ae-missing-release-tag) "EntityUpsertRequest" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
-//
-// @public @deprecated (undocumented)
-export type EntityUpsertRequest = {
-  entity: Entity;
-  relations: EntityRelationSpec[];
-};
-
-// Warning: (ae-missing-release-tag) "EntityUpsertResponse" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
-//
-// @public @deprecated (undocumented)
-export type EntityUpsertResponse = {
-  entityId: string;
-  entity?: Entity;
-};
-
 // Warning: (ae-missing-release-tag) "FileReaderProcessor" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //
 // @public (undocumented)

plugins/catalog-backend/src/catalog/index.ts

@@ -19,8 +19,6 @@ export type {
   EntitiesRequest,
   EntitiesResponse,
   EntityAncestryResponse,
-  EntityUpsertRequest,
-  EntityUpsertResponse,
   PageInfo,
   EntitiesSearchFilter,
   EntityFilter,

plugins/catalog-backend/src/catalog/types.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { Entity, EntityRelationSpec } from '@backstage/catalog-model';
+import { Entity } from '@backstage/catalog-model';
 
 /**
  * A filter expression for entities.
@@ -78,18 +78,6 @@ export type EntitiesResponse = {
   pageInfo: PageInfo;
 };
 
-/** @deprecated This was part of the legacy catalog engine */
-export type EntityUpsertRequest = {
-  entity: Entity;
-  relations: EntityRelationSpec[];
-};
-
-/** @deprecated This was part of the legacy catalog engine */
-export type EntityUpsertResponse = {
-  entityId: string;
-  entity?: Entity;
-};
-
 /** @public */
 export type EntityAncestryResponse = {
   rootEntityRef: string;
@@ -118,20 +106,6 @@ export type EntitiesCatalog = {
     options?: { authorizationToken?: string },
   ): Promise<void>;
 
-  /**
-   * Writes a number of entities efficiently to storage.
-   *
-   * @deprecated This method was part of the legacy catalog engine and will be removed.
-   */
-  batchAddOrUpdateEntities?(
-    requests: EntityUpsertRequest[],
-    options?: {
-      locationId?: string;
-      dryRun?: boolean;
-      outputEntities?: boolean;
-    },
-  ): Promise<EntityUpsertResponse[]>;
-
   /**
    * Returns the full ancestry tree upward along reference edges.
    *

plugins/catalog-backend/src/service/NextEntitiesCatalog.ts

@@ -295,8 +295,4 @@ export class NextEntitiesCatalog implements EntitiesCatalog {
       items,
     };
   }
-
-  async batchAddOrUpdateEntities(): Promise<never> {
-    throw new Error('Not implemented');
-  }
 }

plugins/catalog-backend/src/service/createRouter.test.ts

@@ -38,7 +38,6 @@ describe('createRouter readonly disabled', () => {
     entitiesCatalog = {
       entities: jest.fn(),
       removeEntityByUid: jest.fn(),
-      batchAddOrUpdateEntities: jest.fn(),
       entityAncestry: jest.fn(),
     };
     locationService = {
@@ -332,7 +331,6 @@ describe('createRouter readonly enabled', () => {
     entitiesCatalog = {
       entities: jest.fn(),
       removeEntityByUid: jest.fn(),
-      batchAddOrUpdateEntities: jest.fn(),
       entityAncestry: jest.fn(),
     };
     locationService = {
@@ -466,7 +464,6 @@ describe('NextRouter permissioning', () => {
     entitiesCatalog = {
       entities: jest.fn(),
       removeEntityByUid: jest.fn(),
-      batchAddOrUpdateEntities: jest.fn(),
       entityAncestry: jest.fn(),
     };
     locationService = {