Merge pull request #26212 from backstage/freben/checks

add check reads among the default github app permissions
This commit is contained in:
Fredrik Adelöw
2024-08-26 16:41:23 +02:00
committed by GitHub
3 changed files with 14 additions and 2 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/cli': patch
---
Add `checks: 'read'` for default GitHub app permissions
@@ -114,10 +114,16 @@ export class GithubCreateAppServer {
default_events: ['create', 'delete', 'push', 'repository'],
default_permissions: {
metadata: 'read',
...(this.permissions.includes('members') && { members: 'read' }),
...(this.permissions.includes('read') && { contents: 'read' }),
...(this.permissions.includes('members') && {
members: 'read',
}),
...(this.permissions.includes('read') && {
contents: 'read',
checks: 'read',
}),
...(this.permissions.includes('write') && {
contents: 'write',
checks: 'read',
actions: 'write',
}),
},
@@ -22,6 +22,7 @@ import { paths } from '../../lib/paths';
import { GithubCreateAppServer } from './GithubCreateAppServer';
import fetch from 'node-fetch';
import openBrowser from 'react-dev-utils/openBrowser';
// This is an experimental command that at this point does not support GitHub Enterprise
// due to lacking support for creating apps from manifests.
// https://docs.github.com/en/free-pro-team@latest/developers/apps/creating-a-github-app-from-a-manifest