paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

fix some spelling problems

Browse Source 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
Fredrik Adelöw
2024-09-24 11:17:37 +02:00
parent b878e14f70
commit 5a0afae161
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/vale/config/vocabularies/Backstage/accept.txt
+4
View File
@@ -39,6 +39,8 @@ Brex
broadcasted
bugfixes
builtins
bundler
bundlers
callout
CDNs
Chai
@@ -112,6 +114,7 @@ DOMPurify
don'ts
dynatrace
Dynatrace
dyno
ecco
elasticsearch
Entra
@@ -200,6 +203,7 @@ Knex
knip
Koyeb
KPIs
kroki
Kuang
kubectl
kubernetes
beps/0002-dynamic-frontend-plugins/README.md
+2 -2
View File
@@ -595,7 +595,7 @@ Singleton "might have to" list:
> NOTE: Can leverage [Generate module sharing map](#generate-module-sharing-map).
Component libraries are usually large (thousands of svg icons in @mui/icons) and it is inefficient to share them as a whole. **Tree shaking is disabled for shared modules**. That means sharing large packages in multiple versions will result in a bloated JS in browsers.
Component libraries are usually large (thousands of SVG icons in `@mui/icons`) and it is inefficient to share them as a whole. **Tree shaking is disabled for shared modules**. That means sharing large packages in multiple versions will result in a bloated JS in browsers.
Sharing components like these can be done on module level. Instead of sharing the entire package, share its individual components:
@@ -625,7 +625,7 @@ There is also a conflict with the chunk splitting currently used in the Backstag
#### Webpack chunk optimization
Custom webpack chunk splitting configuration can be problematic, especially when modifying runtime and vendor chunks. Module federation creates its own chunks. Shared modules that are not set up to be eagerly loaded (using the `eager` configuration) **cannot be included inside the entry script**. With a custom chunk splitting setup, they can potentially be forced into the entry script, causing runtime errors. On the other hand, some critical runtime code that has to be in the entry script, cna be forced out of it. This is particularly problematic for the "shell" application.
Custom webpack chunk splitting configuration can be problematic, especially when modifying runtime and vendor chunks. Module federation creates its own chunks. Shared modules that are not set up to be eagerly loaded (using the `eager` configuration) **cannot be included inside the entry script**. With a custom chunk splitting setup, they can potentially be forced into the entry script, causing runtime errors. On the other hand, some critical runtime code that has to be in the entry script, can be forced out of it. This is particularly problematic for the "shell" application.
Chunk optimization should be disabled for the initial implementation.