paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 50 Packages Projects Releases Wiki Activity

Update packages/backend-defaults/src/entrypoints/discovery/HostDiscovery.ts

Browse Source 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
Made-with: Cursor
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
Made-with: Cursor
This commit is contained in:
Fredrik Adelöw
2026-04-03 14:53:43 +02:00
committed by Fredrik Adelöw
parent 308c672680
commit 57543abb7c
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/backend-defaults/src/entrypoints/discovery/HostDiscovery.test.ts
+6 -2
View File
@@ -418,7 +418,11 @@ describe('HostDiscovery', () => {
const originalNodeEnv = env.NODE_ENV;
afterEach(() => {
env.NODE_ENV = originalNodeEnv;
if (originalNodeEnv) {
env.NODE_ENV = originalNodeEnv;
} else {
delete env.NODE_ENV;
}
});
it('warns when backend.baseUrl is a localhost URL and NODE_ENV is production', () => {
@@ -436,7 +440,7 @@ describe('HostDiscovery', () => {
);
expect(logger.warn).toHaveBeenCalledWith(
`backend.baseUrl is set to a localhost URL (http://localhost:7007) but NODE_ENV is 'production'. This is likely a misconfiguration — localhost URLs are not reachable by other services in a deployed environment. Prefer setting it to a routable URL that can be resolved and reached both by your app and by other plugin deployments / services.`,
`backend.baseUrl is set to a localhost URL and NODE_ENV is 'production'. This is likely a misconfiguration — localhost URLs are not reachable by other services in a deployed environment. Prefer setting it to a routable URL that can be resolved and reached both by your app and by other plugin deployments / services.`,
);
});
packages/backend-defaults/src/entrypoints/discovery/HostDiscovery.ts
+1 -1
View File
@@ -164,7 +164,7 @@ export class HostDiscovery implements DiscoveryService {
hostname === '::';
if (isLocalhost && process.env.NODE_ENV === 'production') {
options?.logger?.warn(
`backend.baseUrl is set to a localhost URL (${baseUrl}) but NODE_ENV is '${process.env.NODE_ENV}'. This is likely a misconfiguration — localhost URLs are not reachable by other services in a deployed environment. Prefer setting it to a routable URL that can be resolved and reached both by your app and by other plugin deployments / services.`,
`backend.baseUrl is set to a localhost URL and NODE_ENV is '${process.env.NODE_ENV}'. This is likely a misconfiguration — localhost URLs are not reachable by other services in a deployed environment. Prefer setting it to a routable URL that can be resolved and reached both by your app and by other plugin deployments / services.`,
);
}
} catch {