Merge pull request #8606 from mufaddal7/fix/remove-css

remove internal and inline css
2021-12-23 16:27:15 +01:00
parent 1fc4105bb0 67489db5d6
commit 5284458e18
7 changed files with 38 additions and 19 deletions
@@ -0,0 +1,24 @@
+---
+'@backstage/create-app': patch
+---
+
+removed inline and internal CSS from index.html
+
+To make this change to an existing app, apply the following changes to the `packages/app/public/index.html` file:
+
+Remove internal style
+
+```diff
+- <style>
+-  #root {
+-    min-height: 100%;
+-  }
+- </style>
+```
+
+Remove inline style from the body tag
+
+```diff
+- <body style="margin: 0">
+ <body>
+```
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+remove inline CSS from serve_index.html
@@ -0,0 +1,5 @@
+---
+'@techdocs/cli': patch
+---
+
+remove internal and inline CSS from index.html
@@ -42,11 +42,6 @@
      href="<%= publicPath %>/safari-pinned-tab.svg"
      color="#5bbad5"
    />
-    <style>
-      #root {
-        min-height: 100%;
-      }
-    </style>
    <title><%= config.getString('app.title') %></title>

    <% if (config.has('app.googleAnalyticsTrackingId')) { %>
@@ -103,7 +98,7 @@
    <% } %>
  </head>

-  <body style="margin: 0">
+  <body>
    <noscript>You need to enable JavaScript to run this app.</noscript>
    <div id="root"></div>
    <!--
@@ -10,7 +10,7 @@
    />
    <title>Backstage</title>
  </head>
-  <body style="margin: 0">
+  <body>
    <noscript>You need to enable JavaScript to run this app.</noscript>
    <div id="root"></div>
    <!--
@@ -42,11 +42,6 @@
      href="<%= publicPath %>/safari-pinned-tab.svg"
      color="#5bbad5"
    />
-    <style>
-      #root {
-        min-height: 100%;
-      }
-    </style>
    <title><%= config.getString('app.title') %></title>
    <% if (config.has('app.googleAnalyticsTrackingId')) { %>
    <script
@@ -67,7 +62,7 @@
    </script>
    <% } %>
  </head>
-  <body style="margin: 0">
+  <body>
    <noscript>You need to enable JavaScript to run this app.</noscript>
    <div id="root"></div>
    <!--
@@ -42,14 +42,9 @@
      href="<%= publicPath %>/safari-pinned-tab.svg"
      color="#5bbad5"
    />
-    <style>
-      #root {
-        min-height: 100%;
-      }
-    </style>
    <title><%= config.getString('app.title') %></title>
  </head>
-  <body style="margin: 0">
+  <body>
    <noscript>You need to enable JavaScript to run this app.</noscript>
    <div id="root"></div>
    <!--