Incorporated the feedback.
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
This commit is contained in:
@@ -29,7 +29,6 @@ import { AnyApiFactory } from '../apis';
|
||||
*/
|
||||
export class PluginImpl<
|
||||
PluginInputOptions extends {},
|
||||
PluginOptions extends {},
|
||||
Routes extends AnyRoutes,
|
||||
ExternalRoutes extends AnyExternalRoutes,
|
||||
> implements BackstagePlugin<PluginInputOptions, Routes, ExternalRoutes>
|
||||
@@ -37,7 +36,6 @@ export class PluginImpl<
|
||||
constructor(
|
||||
private readonly config: PluginConfig<
|
||||
PluginInputOptions,
|
||||
PluginOptions,
|
||||
Routes,
|
||||
ExternalRoutes
|
||||
>,
|
||||
@@ -95,16 +93,10 @@ export class PluginImpl<
|
||||
*/
|
||||
export function createPlugin<
|
||||
PluginInputOptions extends {},
|
||||
PluginOptions extends {},
|
||||
Routes extends AnyRoutes = {},
|
||||
ExternalRoutes extends AnyExternalRoutes = {},
|
||||
>(
|
||||
config: PluginConfig<
|
||||
PluginInputOptions,
|
||||
PluginOptions,
|
||||
Routes,
|
||||
ExternalRoutes
|
||||
>,
|
||||
config: PluginConfig<PluginInputOptions, Routes, ExternalRoutes>,
|
||||
): BackstagePlugin<PluginInputOptions, Routes, ExternalRoutes> {
|
||||
return new PluginImpl(config);
|
||||
}
|
||||
|
||||
@@ -83,7 +83,6 @@ export type PluginFeatureFlagConfig = {
|
||||
*/
|
||||
export type PluginConfig<
|
||||
PluginInputOptions extends {},
|
||||
PluginOptions extends {},
|
||||
Routes extends AnyRoutes,
|
||||
ExternalRoutes extends AnyExternalRoutes,
|
||||
> = {
|
||||
@@ -92,7 +91,7 @@ export type PluginConfig<
|
||||
routes?: Routes;
|
||||
externalRoutes?: ExternalRoutes;
|
||||
featureFlags?: PluginFeatureFlagConfig[];
|
||||
__experimentalConfigure?(options?: PluginInputOptions): PluginOptions;
|
||||
__experimentalConfigure?(options?: PluginInputOptions): {};
|
||||
};
|
||||
|
||||
/**
|
||||
|
||||
@@ -13,5 +13,6 @@
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
import './plugin';
|
||||
|
||||
export * from '@backstage/plugin-catalog';
|
||||
|
||||
Reference in New Issue
Block a user