fix: review

Signed-off-by: mario ma <mario.ma.node@gmail.com>
This commit is contained in:
mario ma
2025-04-15 22:20:31 +08:00
parent f67caac211
commit 4be9104eeb
4 changed files with 8 additions and 8 deletions
+3 -3
View File
@@ -116,8 +116,8 @@ export const userSettingsTranslationRef: TranslationRef<
readonly 'featureFlags.emptyFlags.description': 'Feature Flags make it possible for plugins to register features in Backstage for users to opt into. You can use this to split out logic in your code for manual A/B testing, etc.';
readonly 'featureFlags.flagItem.title.disable': 'Disable';
readonly 'featureFlags.flagItem.title.enable': 'Enable';
readonly 'featureFlags.flagItem.subTitle.registeredInApplication': 'Registered in the application';
readonly 'featureFlags.flagItem.subTitle.registeredInPlugin': 'Registered in {{pluginId}} plugin';
readonly 'featureFlags.flagItem.subtitle.registeredInApplication': 'Registered in the application';
readonly 'featureFlags.flagItem.subtitle.registeredInPlugin': 'Registered in {{pluginId}} plugin';
readonly 'languageToggle.select': 'Select language {{language}}';
readonly 'languageToggle.title': 'Language';
readonly 'languageToggle.description': 'Change the language';
@@ -153,7 +153,7 @@ export const userSettingsTranslationRef: TranslationRef<
readonly 'defaultSettingsPage.tabsTitle.authProviders': 'Authentication Providers';
readonly 'defaultSettingsPage.tabsTitle.general': 'General';
readonly 'settingsLayout.title': 'Settings';
readonly sideBarTitle: 'Settings';
readonly sidebarTitle: 'Settings';
}
>;
@@ -38,10 +38,10 @@ const getSecondaryText = (
return flag.description;
}
return flag.pluginId
? t('featureFlags.flagItem.subTitle.registeredInPlugin', {
? t('featureFlags.flagItem.subtitle.registeredInPlugin', {
pluginId: flag.pluginId,
})
: t('featureFlags.flagItem.subTitle.registeredInApplication');
: t('featureFlags.flagItem.subtitle.registeredInApplication');
};
export const FlagItem = ({ flag, enabled, toggleHandler }: Props) => {
@@ -26,5 +26,5 @@ export const Settings = (props: { icon?: IconComponent }) => {
const routePath = useRouteRef(settingsRouteRef);
const Icon = props.icon ? props.icon : SettingsIcon;
const { t } = useTranslationRef(userSettingsTranslationRef);
return <SidebarItem text={t('sideBarTitle')} to={routePath()} icon={Icon} />;
return <SidebarItem text={t('sidebarTitle')} to={routePath()} icon={Icon} />;
};
+2 -2
View File
@@ -109,7 +109,7 @@ export const userSettingsTranslationRef = createTranslationRef({
disable: 'Disable',
enable: 'Enable',
},
subTitle: {
subtitle: {
registeredInApplication: 'Registered in the application',
registeredInPlugin: 'Registered in {{pluginId}} plugin',
},
@@ -118,6 +118,6 @@ export const userSettingsTranslationRef = createTranslationRef({
settingsLayout: {
title: 'Settings',
},
sideBarTitle: 'Settings',
sidebarTitle: 'Settings',
},
});