Merge pull request #8746 from backstage/rugvip/icons

search: fix slow build + cli: fix import rule edge-case

.changeset/rotten-olives-shop.md

@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Update `config/eslint.js` to forbid imports of `@material-ui/icons/` as well.

packages/cli/config/eslint.js

@@ -80,6 +80,10 @@ module.exports = {
             name: '@material-ui/icons',
             message: "Please import '@material-ui/icons/<Icon>' instead.",
           },
+          {
+            name: '@material-ui/icons/', // because this is possible too ._.
+            message: "Please import '@material-ui/icons/<Icon>' instead.",
+          },
           ...require('module').builtinModules,
         ],
         // Avoid cross-package imports

plugins/search/src/components/SearchModal/SearchModal.tsx

@@ -25,7 +25,7 @@ import {
   List,
   Paper,
 } from '@material-ui/core';
-import { Launch } from '@material-ui/icons/';
+import LaunchIcon from '@material-ui/icons/Launch';
 import { makeStyles } from '@material-ui/core/styles';
 import { SearchBar } from '../SearchBar';
 import { DefaultResultListItem } from '../DefaultResultListItem';
@@ -96,7 +96,7 @@ export const Modal = ({ open = true, toggleModal }: SearchModalProps) => {
           <Grid item>
             <Link onClick={toggleModal} to={`${getSearchLink()}?query=${term}`}>
               <span className={classes.viewResultsLink}>View Full Results</span>
-              <Launch color="primary" />
+              <LaunchIcon color="primary" />
             </Link>
           </Grid>
         </Grid>