paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 25 Packages Projects Releases Wiki Activity

auth: Fix SingleSingInPage to not ask for login on every page refresh

Browse Source 
1. Disable instantPopup when requesting Backstage identity. If it is set to true, existing user sessions are discarded - from core-api/src/lib/AuthSessionManager/RefreshingAuthSessionManager.ts

2. The auto prop should be true by default, to trigger a log-in attempt when the SingleSignInPage component is loaded

Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>
This commit is contained in:
Himanshu Mishra
2021-05-17 23:00:32 +02:00
parent 6f02dacdc8
commit 477872d149
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/layout/SignInPage/SignInPage.tsx
+10 -12
View File
@@ -14,18 +14,18 @@
* limitations under the License.
*/
import { configApiRef, SignInPageProps, useApi } from '@backstage/core-api';
import { Button, Grid, Typography } from '@material-ui/core';
import React, { useEffect, useState } from 'react';
import { Page } from '../Page';
import { Header } from '../Header';
import { Progress } from '../../components/Progress';
import { Content } from '../Content/Content';
import { ContentHeader } from '../ContentHeader/ContentHeader';
import { Grid, Button, Typography } from '@material-ui/core';
import { SignInPageProps, useApi, configApiRef } from '@backstage/core-api';
import { useSignInProviders, getSignInProviders } from './providers';
import { IdentityProviders, SignInProviderConfig } from './types';
import { Progress } from '../../components/Progress';
import { GridItem, useStyles } from './styles';
import { Header } from '../Header';
import { InfoCard } from '../InfoCard';
import { Page } from '../Page';
import { getSignInProviders, useSignInProviders } from './providers';
import { GridItem, useStyles } from './styles';
import { IdentityProviders, SignInProviderConfig } from './types';
type MultiSignInPageProps = SignInPageProps & {
providers: IdentityProviders;
@@ -81,7 +81,7 @@ export const MultiSignInPage = ({
export const SingleSignInPage = ({
onResult,
provider,
auto,
auto = true,
}: SingleSignInPageProps) => {
const classes = useStyles();
const authApi = useApi(provider.apiRef);
@@ -92,9 +92,7 @@ export const SingleSignInPage = ({
useEffect(() => {
const login = async () => {
const identity = await authApi.getBackstageIdentity({
instantPopup: true,
});
const identity = await authApi.getBackstageIdentity();
const profile = await authApi.getProfile();
onResult({