paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 42 Packages Projects Releases Wiki Activity

frontend-app-api: revert predicate traversal cleanup

Browse Source 
Restore the more defensive predicate traversal implementation after the narrowing cleanup turned out not to be worth the type fallout.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
This commit is contained in:
Patrik Oldsberg
2026-03-17 12:18:04 +01:00
parent 0d6596f4e7
commit 46b530378d
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/frontend-app-api/src/wiring/predicates.ts
+12 -8
View File
@@ -160,17 +160,21 @@ function extractPredicateKeyNames(
if (typeof predicate !== 'object' || predicate === null) {
return [];
}
const typedPredicate = predicate as FilterPredicate & Record<string, unknown>;
if ('$all' in typedPredicate && Array.isArray(typedPredicate.$all)) {
return typedPredicate.$all.flatMap(p => extractPredicateKeyNames(p, key));
const obj = predicate as Record<string, unknown>;
if (Array.isArray(obj.$all)) {
return (obj.$all as FilterPredicate[]).flatMap(p =>
extractPredicateKeyNames(p, key),
);
}
if ('$any' in typedPredicate && Array.isArray(typedPredicate.$any)) {
return typedPredicate.$any.flatMap(p => extractPredicateKeyNames(p, key));
if (Array.isArray(obj.$any)) {
return (obj.$any as FilterPredicate[]).flatMap(p =>
extractPredicateKeyNames(p, key),
);
}
if ('$not' in typedPredicate && typedPredicate.$not !== undefined) {
return extractPredicateKeyNames(typedPredicate.$not, key);
if (obj.$not !== undefined) {
return extractPredicateKeyNames(obj.$not as FilterPredicate, key);
}
const value = typedPredicate[key];
const value = obj[key];
if (typeof value === 'object' && value !== null && !Array.isArray(value)) {
const contains = (value as Record<string, unknown>).$contains;
if (typeof contains === 'string') {