Fix review feedback

Signed-off-by: dlaird-ovo <daniel.laird@ovo.com>
This commit is contained in:
dlaird-ovo
2023-03-15 11:22:24 +00:00
parent 76b1c126bd
commit 44e3878a8d
@@ -24,18 +24,25 @@ import {
const kubernetesClusterResource: Entity = {
apiVersion: '',
kind: 'resource',
kind: 'Resource',
metadata: { name: 'aKubernetesCluster' },
spec: { type: 'kubernetes-cluster' },
};
const databaseResource: Entity = {
apiVersion: '',
kind: 'resource',
kind: 'Resource',
metadata: { name: 'aDatabase' },
spec: { type: 'database' },
};
const notResource: Entity = {
apiVersion: '',
kind: 'not-Resource',
metadata: { name: 'aService' },
spec: { type: 'service' },
};
const serviceComponent: Entity = {
apiVersion: '',
kind: 'component',
@@ -79,10 +86,10 @@ const bNamespace: Entity = {
};
describe('isResourceType', () => {
it('should false on non component kinds', () => {
const checkEntity = isResourceType('service');
it('should false on non resource kinds', () => {
const checkEntity = isResourceType('kubernetes-cluster');
expect(checkEntity(notComponent)).not.toBeTruthy();
expect(checkEntity(notResource)).not.toBeTruthy();
});
it('should check for the intended type', () => {
const checkEntity = isResourceType('kubernetes-cluster');