paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 41 Packages Projects Releases Wiki Activity

added handling of undefined to return an empty array

Browse Source 
Signed-off-by: Jonah Grimes <jgrimes@appriss.com>
This commit is contained in:
Jonah Grimes
2021-05-11 17:25:53 -04:00
parent f1cca64bed
commit 44220f26a7
2 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog/src/components/RelatedEntitiesCard/RelatedEntitiesCard.tsx
+1 -1
View File
@@ -38,7 +38,7 @@ type Props<T extends Entity> = {
relationType: string;
emptyMessage: string;
emptyHelpLink: string;
asRenderableEntities: (entities: Entity[] | undefined) => T[];
asRenderableEntities: (entities?: Entity[]) => T[];
};
export function RelatedEntitiesCard<T extends Entity>({
plugins/catalog/src/components/RelatedEntitiesCard/presets.ts
+6 -9
View File
@@ -31,9 +31,8 @@ export const componentEntityColumns: TableColumn<ComponentEntity>[] = [
];
export const componentEntityHelpLink: string =
'https://backstage.io/docs/features/software-catalog/descriptor-format#kind-component';
export const asComponentEntities = (
entities: Entity[] | undefined,
): ComponentEntity[] => entities as ComponentEntity[];
export const asComponentEntities = (entities?: Entity[]): ComponentEntity[] =>
(entities as ComponentEntity[]) || new Array<ComponentEntity>();
export const resourceEntityColumns: TableColumn<ResourceEntity>[] = [
EntityTable.columns.createEntityRefColumn({ defaultKind: 'resource' }),
@@ -44,9 +43,8 @@ export const resourceEntityColumns: TableColumn<ResourceEntity>[] = [
];
export const resourceEntityHelpLink: string =
'https://backstage.io/docs/features/software-catalog/descriptor-format#kind-resource';
export const asResourceEntities = (
entities: Entity[] | undefined,
): ResourceEntity[] => entities as ResourceEntity[];
export const asResourceEntities = (entities?: Entity[]): ResourceEntity[] =>
(entities as ResourceEntity[]) || new Array<ResourceEntity>();
export const systemEntityColumns: TableColumn<SystemEntity>[] = [
EntityTable.columns.createEntityRefColumn({ defaultKind: 'system' }),
@@ -55,6 +53,5 @@ export const systemEntityColumns: TableColumn<SystemEntity>[] = [
];
export const systemEntityHelpLink: string =
'https://backstage.io/docs/features/software-catalog/descriptor-format#kind-system';
export const asSystemEntities = (
entities: Entity[] | undefined,
): SystemEntity[] => entities as SystemEntity[];
export const asSystemEntities = (entities?: Entity[]): SystemEntity[] =>
(entities as SystemEntity[]) || new Array<SystemEntity>();