Don't check exceptions

Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk>
This commit is contained in:
Karan Shah
2022-03-03 15:15:58 +00:00
parent 8c4e3574ef
commit 4239b8dba6
2 changed files with 5 additions and 23 deletions
@@ -34,7 +34,7 @@ import { errorApiRef } from '@backstage/core-plugin-api';
import { rest } from 'msw';
import { setupServer } from 'msw/node';
describe('EntityAirbrakeContent', () => {
describe('EntityAirbrakeWidget', () => {
const worker = setupServer();
setupRequestMockHandlers(worker);
@@ -29,7 +29,6 @@ import { ErrorApi, errorApiRef, useApi } from '@backstage/core-plugin-api';
import { airbrakeApiRef } from '../../api';
import useAsync from 'react-use/lib/useAsync';
import { AIRBRAKE_PROJECT_ID_ANNOTATION, useProjectId } from '../useProjectId';
import { NoProjectIdError } from '../../api/AirbrakeApi';
const useStyles = makeStyles<BackstageTheme>(() => ({
multilineText: {
@@ -54,38 +53,21 @@ export const EntityAirbrakeWidget = ({ entity }: { entity: Entity }) => {
ComponentState.Loading,
);
useEffect(() => {
if (!projectId) {
setComponentState(ComponentState.NoProjectId);
} else {
setComponentState(ComponentState.Loading);
}
}, [projectId]);
const { loading, value, error } = useAsync(async () => {
const { loading, value } = useAsync(async () => {
try {
const result = await airbrakeApi.fetchGroups(projectId);
setComponentState(ComponentState.Loaded);
return result;
} catch (e) {
if (e instanceof NoProjectIdError) {
if (!projectId) {
setComponentState(ComponentState.NoProjectId);
} else {
setComponentState(ComponentState.Error);
errorApi.post(e);
}
throw e;
}
}, [airbrakeApi, projectId]);
useEffect(() => {
if (
componentState === ComponentState.Error &&
error &&
!(error instanceof NoProjectIdError)
) {
errorApi.post(error);
}
}, [componentState, error, errorApi]);
}, [airbrakeApi, errorApi, projectId]);
useEffect(() => {
if (loading) {