paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 20 Packages Projects Releases Wiki Activity

chore: switch around the params to the factories

Browse Source 
Signed-off-by: blam <ben@blam.sh>
This commit is contained in:
blam
2024-07-18 14:59:02 +02:00
parent 5eaaf807fa
commit 3f257d25e2
4 changed files with 33 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/dry-squids-tap.md
+1 -1
View File
@@ -14,7 +14,7 @@ const EntityCardBlueprint = createExtensionBlueprint({
output: {
element: coreExtensionData.reactElement,
},
factory(_, params: { text: string }) {
factory(params: { text: string }) {
return {
element: <h1>{params.text}</h1>,
};
packages/frontend-plugin-api/api-report.md
+3 -3
View File
@@ -527,12 +527,12 @@ export interface CreateExtensionBlueprintOptions<
disabled?: boolean;
// (undocumented)
factory(
params: TParams,
context: {
node: AppNode;
config: TConfig;
inputs: Expand<ResolvedExtensionInputs<TInputs>>;
},
params: TParams,
): Expand<ExtensionDataValues<TOutput>>;
// (undocumented)
inputs?: TInputs;
@@ -899,20 +899,20 @@ export interface ExtensionBlueprint<
configSchema?: PortableSchema<TConfig>;
params: TParams;
factory?(
params: TParams,
context: {
node: AppNode;
config: TConfig;
inputs: Expand<ResolvedExtensionInputs<TInputs>>;
orignalFactory(
params?: TParams,
context?: {
node?: AppNode;
config?: TConfig;
inputs?: Expand<ResolvedExtensionInputs<TInputs>>;
},
params?: TParams,
): Expand<ExtensionDataValues<TOutput>>;
},
params: TParams,
): Expand<ExtensionDataValues<TOutput>>;
}): ExtensionDefinition<TConfig>;
}
packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx
+3 -3
View File
@@ -27,7 +27,7 @@ describe('createExtensionBlueprint', () => {
output: {
element: coreExtensionData.reactElement,
},
factory(_, params: { text: string }) {
factory(params: { text: string }) {
return {
element: <h1>{params.text}</h1>,
};
@@ -78,7 +78,7 @@ describe('createExtensionBlueprint', () => {
output: {
element: coreExtensionData.reactElement,
},
factory(_, params: { text: string }) {
factory(params: { text: string }) {
return {
element: <h1>{params.text}</h1>,
};
@@ -90,7 +90,7 @@ describe('createExtensionBlueprint', () => {
params: {
text: 'Hello, world!',
},
factory(_, params: { text: string }) {
factory(params: { text: string }) {
return {
element: <h2>{params.text}</h2>,
};
packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts
+26 -35
View File
@@ -43,12 +43,12 @@ export interface CreateExtensionBlueprintOptions<
output: TOutput;
configSchema?: PortableSchema<TConfig>;
factory(
params: TParams,
context: {
node: AppNode;
config: TConfig;
inputs: Expand<ResolvedExtensionInputs<TInputs>>;
},
params: TParams,
): Expand<ExtensionDataValues<TOutput>>;
}
@@ -71,20 +71,20 @@ export interface ExtensionBlueprint<
configSchema?: PortableSchema<TConfig>;
params: TParams;
factory?(
params: TParams,
context: {
node: AppNode;
config: TConfig;
inputs: Expand<ResolvedExtensionInputs<TInputs>>;
orignalFactory(
params?: TParams,
context?: {
node?: AppNode;
config?: TConfig;
inputs?: Expand<ResolvedExtensionInputs<TInputs>>;
},
params?: TParams,
): Expand<ExtensionDataValues<TOutput>>;
},
params: TParams,
): Expand<ExtensionDataValues<TOutput>>;
}): ExtensionDefinition<TConfig>;
}
@@ -117,20 +117,20 @@ class ExtensionBlueprintImpl<
configSchema?: PortableSchema<TConfig>;
params: TParams;
factory?(
params: TParams,
context: {
node: AppNode;
config: TConfig;
inputs: Expand<ResolvedExtensionInputs<TInputs>>;
orignalFactory(
params?: TParams,
context?: {
node?: AppNode;
config?: TConfig;
inputs?: Expand<ResolvedExtensionInputs<TInputs>>;
},
params?: TParams,
): Expand<ExtensionDataValues<TOutput>>;
},
params: TParams,
): Expand<ExtensionDataValues<TOutput>>;
}): ExtensionDefinition<TConfig> {
return createExtension({
@@ -144,39 +144,30 @@ class ExtensionBlueprintImpl<
configSchema: args.configSchema ?? this.options.configSchema, // TODO: some config merging or smth
factory: ({ node, config, inputs }) => {
if (args.factory) {
return args.factory(
{
node,
config,
inputs,
orignalFactory: (
innerContext?: {
config?: TConfig;
inputs?: Expand<ResolvedExtensionInputs<TInputs>>;
},
innerParams?: TParams,
) =>
this.options.factory(
{
node,
config: innerContext?.config ?? config,
inputs: innerContext?.inputs ?? inputs,
},
innerParams ?? args.params,
),
},
args.params,
);
}
return this.options.factory(
{
return args.factory(args.params, {
node,
config,
inputs,
},
args.params,
);
orignalFactory: (
innerParams?: TParams,
innerContext?: {
config?: TConfig;
inputs?: Expand<ResolvedExtensionInputs<TInputs>>;
},
) =>
this.options.factory(innerParams ?? args.params, {
node,
config: innerContext?.config ?? config,
inputs: innerContext?.inputs ?? inputs,
}),
});
}
return this.options.factory(args.params, {
node,
config,
inputs,
});
},
});
}